Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose SerializationService in ObjectDataOutput #16046

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@vbekiaris
Copy link
Contributor

vbekiaris commented Nov 18, 2019

SerializationService is now internal API and shouldn't be accessible
via public API methods.

Instead, internal interfaces/implementations of ObjectDataOutput
implement SerializationServiceSupport and we make use of this
interface in PreJoinCacheConfig where serialization service is
needed to implement deferred serialization/deserialization of
user customizations.

thanks @sancar for noticing the issue

SerializationService is now internal API and shouldn't be accessible
via public API methods.
@vbekiaris vbekiaris requested a review from sancar Nov 18, 2019
@vbekiaris vbekiaris self-assigned this Nov 18, 2019
@mmedenjak mmedenjak added this to the 4.0 milestone Nov 18, 2019
@sancar
sancar approved these changes Nov 19, 2019
@sancar

This comment has been minimized.

Copy link
Member

sancar commented Nov 19, 2019

@vbekiaris Are you gonna remove getSerializationService from ObjectDataInput as well ?

@vbekiaris

This comment has been minimized.

Copy link
Contributor Author

vbekiaris commented Nov 19, 2019

@sancar I am preparing a separate PR to also remove Data occurences from ObjectDataInput/Output as discussed here. I will include removal of SerializationService from ObjectDataInput in that PR.

@vbekiaris vbekiaris merged commit dbdeb12 into hazelcast:master Nov 19, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@vbekiaris vbekiaris deleted the vbekiaris:fixes/4.0/serserv-non-public branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.