Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC: Add run script and console command operations to client #16071

Conversation

@puzpuzpuz
Copy link
Contributor

puzpuzpuz commented Nov 20, 2019

  • The following operations are added to the client side ManagementCenterService:
    • runScript
    • runConsoleCommand
  • Uses new hz:mc executor for the new tasks, so they get executed on a small, fixed-sized thread pool. This guarantees that invalid scripts (e.g. an infinite loop) don't do any harm to any other executors and operations waiting to be run there (although, they still can harm machine by consuming its resources, but that's expected)
  • Renames response parameter for matchMCConfig operation in a more consistent way
  • Includes some minor updates in the built-in help for console commands
  • Fixes a bug in l.remove console command: string value based variant was never called

Client protocol PR: hazelcast/hazelcast-client-protocol#263

@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz:v4.0/enhancement/mc-client-scripts-and-console-commands branch from 5192266 to 73ef697 Nov 21, 2019
@puzpuzpuz puzpuzpuz marked this pull request as ready for review Nov 21, 2019
@puzpuzpuz puzpuzpuz requested a review from hazelcast/clients as a code owner Nov 21, 2019
@puzpuzpuz puzpuzpuz requested a review from emre-aydin Nov 21, 2019
…mc-client-scripts-and-console-commands
@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Nov 21, 2019

run-lab-run

…mc-client-scripts-and-console-commands
Copy link
Contributor

emre-aydin left a comment

Kudos for going the extra mile and adding documentation to console commands!

puzpuzpuz added 3 commits Nov 22, 2019
…mc-client-scripts-and-console-commands
…mc-client-scripts-and-console-commands
@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz:v4.0/enhancement/mc-client-scripts-and-console-commands branch from 28d5156 to e3e562e Nov 25, 2019
@puzpuzpuz puzpuzpuz changed the title MC: Add run script and console command operations to client [WIP] MC: Add run script and console command operations to client Nov 25, 2019
@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz:v4.0/enhancement/mc-client-scripts-and-console-commands branch from 4821d6c to e976fd7 Nov 25, 2019
@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz:v4.0/enhancement/mc-client-scripts-and-console-commands branch from e976fd7 to 9445ff9 Nov 25, 2019
…ockingMessageTask to hz:mc executor
@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz:v4.0/enhancement/mc-client-scripts-and-console-commands branch from 9445ff9 to 63e2226 Nov 25, 2019
@puzpuzpuz puzpuzpuz changed the title [WIP] MC: Add run script and console command operations to client MC: Add run script and console command operations to client Nov 25, 2019
@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Nov 25, 2019

@sancar could you take another look? I've migrated both tasks to the new hz:mc executor.

@puzpuzpuz puzpuzpuz requested a review from sancar Nov 26, 2019
@sancar
sancar approved these changes Nov 26, 2019
@puzpuzpuz puzpuzpuz merged commit d01b776 into hazelcast:master Nov 26, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@puzpuzpuz puzpuzpuz deleted the puzpuzpuz:v4.0/enhancement/mc-client-scripts-and-console-commands branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.