Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames GroupProperty to ClusterProperty #16076

Merged
merged 4 commits into from Nov 22, 2019

Conversation

@vbekiaris
Copy link
Contributor

vbekiaris commented Nov 21, 2019

In Hazelcast 4.0 group name was replaced by cluster-name in
configuration, so "group" makes no longer sense.

First commit replaces certain text occurrences of "group" to "cluster" (when related to group property). Second commit is the result of renaming action and third commit fixes a checkstyle issue that occurred as a result of renaming.

Fixes #15921

@vbekiaris vbekiaris added this to the 4.0 milestone Nov 21, 2019
@vbekiaris vbekiaris requested a review from hazelcast/clients as a code owner Nov 21, 2019
@mmedenjak mmedenjak self-requested a review Nov 22, 2019
@sancar
sancar approved these changes Nov 22, 2019
vbekiaris added 3 commits Nov 21, 2019
In Hazelcast 4.0 group name was replaced by cluster name in
configuration, so "group" makes no longer sense.
@vbekiaris vbekiaris force-pushed the vbekiaris:fixes/4.0/rename-group-property branch from 0bb42fb to e2c99a1 Nov 22, 2019
@vbekiaris

This comment has been minimized.

Copy link
Contributor Author

vbekiaris commented Nov 22, 2019

run-lab-run

@vbekiaris vbekiaris merged commit 2d78e97 into hazelcast:master Nov 22, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@vbekiaris vbekiaris deleted the vbekiaris:fixes/4.0/rename-group-property branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.