Fix size based eviction when cluster scaled down #18871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmircik
added
Type: Defect
Source: Community
ahmetmircik
changed the title
mmedenjak
added
Team: Core
Source: Internal
mmedenjak
approved these changes
Jun 16, 2021
hazelcast/src/main/java/com/hazelcast/map/impl/operation/MapReplicationStateHolder.java
Show resolved
Hide resolved
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2008-2021, Hazelcast, Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
always asking myself that.
blazember
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14046
Modification:
Main changes are in replication operation. In this operation, before putting entries into record-store, we first calculate
ownedEntryCountOnThisNode. If this value is below the per-node max-size, we put entries till we reach the max-size. After reaching it, we quit putting entries.This is an approximation approach. Base on my tests it is working and keeps per-node map-size around set value.
Forward-port: #18873