Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HZ-636 Do not create map config with phone home service #19900

Merged
merged 2 commits into from Nov 8, 2021

Conversation

ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Nov 5, 2021

Happens when phone home is enabled.

Closes: #19137
Backport of: #19903

@ahmetmircik ahmetmircik added this to the 5.0.1 milestone Nov 5, 2021
@hazelcast hazelcast deleted a comment from hz-devops-test Nov 5, 2021
@AyberkSorgun AyberkSorgun changed the title Do not create map config with phone home service HZ-636 Do not create map config with phone home service Nov 5, 2021
@swarmia
Copy link

swarmia bot commented Nov 5, 2021

@zhmaeff
Copy link
Contributor

zhmaeff commented Nov 5, 2021

@erosb should this fix be also backported to 4.0.z 4.1.z 4.2.z as you did for #19833 ?

@erosb
Copy link
Contributor

erosb commented Nov 5, 2021

@zhmaeff @ahmetmircik yes please do raise backport PRs. Thanks a lot for the fix.

Copy link
Collaborator

@vbekiaris vbekiaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmetmircik thanks for the fix.

import static org.junit.Assert.assertTrue;

@RunWith(HazelcastSerialClassRunner.class)
@Category({QuickTest.class})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can the test be also ParallelJVMTest so it is executed in the parallel test execution phase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also nit: this test could be merged with com.hazelcast.internal.util.phonehome.GhostMapTest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all done.

@ahmetmircik ahmetmircik merged commit d9fb7bb into hazelcast:5.0.z Nov 8, 2021
@ahmetmircik ahmetmircik deleted the fix/5.0.z/phoneHome branch November 8, 2021 09:49
@zhmaeff
Copy link
Contributor

zhmaeff commented Nov 8, 2021

@ahmetmircik thank you for this fix! Pls do not forget to raise backports for 4.0.z and 4.1.z.

@ahmetmircik
Copy link
Member Author

@zhmaeff Can you verify the issue exists on that branches also?

@erosb
Copy link
Contributor

erosb commented Nov 8, 2021

There are open backport PRs currently with the phonehome improvements for 4.0.z and 4.1.z:

I will push the changes in this PR into those branches.

@zhmaeff
Copy link
Contributor

zhmaeff commented Nov 8, 2021

@ahmetmircik @erosb Oh, I thought it was already merged.

erosb pushed a commit to erosb/hazelcast that referenced this pull request Nov 8, 2021
erosb pushed a commit to erosb/hazelcast that referenced this pull request Nov 8, 2021
erosb pushed a commit that referenced this pull request Nov 9, 2021
* backporting #17892 and its follow-ups to 4.1.z

* fixing HZ-650

* checkstyle fixes

* test code cleanup

* fixing compilation failure

* backporting ClassPathFormattingTest

* removing unused metrics

* backporting #19900

Co-authored-by: Ahmet Mircik <ahmetmircik@gmail.com>
erosb pushed a commit that referenced this pull request Nov 9, 2021
* backporting #17892 and its follow-ups to 4.0.z

* fixing HZ-650

* checkstyle fixes

* test code cleanup

* fixing test compilation error

* removing unused metrics

* backporting ClassPathFormattingTest

* backporting #19900

Co-authored-by: Ahmet Mircik <ahmetmircik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants