New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HZ-636 Do not create map config with phone home service #19900
Conversation
7096455
to
306da71
Compare
✅ Linked to HZ-636 · 5.0-BETA-1 mismatching map config [GH#19137] |
@zhmaeff @ahmetmircik yes please do raise backport PRs. Thanks a lot for the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmetmircik thanks for the fix.
import static org.junit.Assert.assertTrue; | ||
|
||
@RunWith(HazelcastSerialClassRunner.class) | ||
@Category({QuickTest.class}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can the test be also ParallelJVMTest
so it is executed in the parallel test execution phase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also nit: this test could be merged with com.hazelcast.internal.util.phonehome.GhostMapTest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all done.
@ahmetmircik thank you for this fix! Pls do not forget to raise backports for |
@zhmaeff Can you verify the issue exists on that branches also? |
There are open backport PRs currently with the phonehome improvements for 4.0.z and 4.1.z: I will push the changes in this PR into those branches. |
@ahmetmircik @erosb Oh, I thought it was already merged. |
Happens when phone home is enabled.
Closes: #19137
Backport of: #19903