[API-1250] Rename cloneWithBuilder to newBuilderWithClone for GenericRecords
#21730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, the APIs of the `GenericRecord` and `GenericRecordBuilder` interfaces are updated to reflect this change, along with formatting fixes. Also, lots of the documentation is corrected to have the proper wording for Compact serialization and some code snippets are updated with the new APIs.
mdumandag
added
Team: Client
Team: Documentation
Type: Cleanup
Source: Internal
ihsandemir
approved these changes
Jul 25, 2022
|
@mdumandag Can you also rename the following? |
srknzl
suggested changes
Jul 25, 2022
hazelcast/src/main/java/com/hazelcast/nio/serialization/GenericRecord.java
Outdated
Show resolved
Hide resolved
hazelcast/src/main/java/com/hazelcast/nio/serialization/GenericRecordBuilder.java
Outdated
Show resolved
Hide resolved
hazelcast/src/main/java/com/hazelcast/nio/serialization/GenericRecordBuilder.java
Outdated
Show resolved
Hide resolved
srknzl
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, the APIs of the
GenericRecordandGenericRecordBuilderinterfaces are updated to reflect this change, along with formatting
fixes.
Also, lots of the documentation is corrected to have the proper
wording for Compact serialization and some code snippets are updated
with the new APIs.