mapCleared is added to EntryListener #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some checkstyle issues. |
|
Looking into checkstyle. It is probably because some other checkstyle pr is merged in the process. :( |
|
I see that a related test is also failed. |
|
verify |
added 2 commits
June 23, 2014 14:54
| } | ||
| getLocalMultiMapStatsImpl(event.getName()).incrementReceivedEvents(); | ||
| } | ||
| // public void dispatchEvent(MultiMapEvent event, EventListener listener) { |
There was a problem hiding this comment.
these should be removed I guess ?
| return new EntryEvent<K, V>(name, member, | ||
| event.getEventType().getType(), key, oldValue, value); | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe you can decrease code duplication later.
|
Can you do a rebase? |
|
My masters, as your humble servant, I accept your decision as order. I should be get to work then. |
|
verify |
enesakar
added a commit
that referenced
this pull request
Jun 24, 2014
mapCleared is added to EntryListener
| for (Object o : resultMap.values()) { | ||
| numberOfAffectedEntries += (Integer) o; | ||
| } | ||
| publishMapEvent(numberOfAffectedEntries, EntryEventType.CLEAR_ALL); |
There was a problem hiding this comment.
Maybe you can also think about not to fire an event if a map is empty or has no affected entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes to reviewers:
On multimap clear, mapCleared method will be called. Before we were firing event for each key as removed.
When evictAll/clearAll is called from nodes, event will be fired in that node after all operations in partition threads finished
When evictAll/clearAll is called from clients , event will be fired in the remote node that request send in reduce phase meaning after all operations in partition threads returned.
Not sure what to do in webfilter leaved as todo.
Not sure what to do in beans for statistics leaved as todo.
Tests for multimap and map listeners related to evictAll and clearAll is added for both client and node. And even tested what happens if node is firing the event and client was the one listening.
Note for the client team(I will also add as issue to client issue lists ), PortableEntryEvent is changed, and should be changed accordingly in C++ and C# clients also.
fixes #2789