Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces LazyMapEntry. #5589

Conversation

ahmetmircik
Copy link
Member

It provides on-demand deserialization of key-value pairs for map entry which is passed in EntryProcessor#process & EntryBackupProcessor#processBackup methods.

closes #5301
closes #5611

@gurbuzali
Copy link
Contributor

👍

*
* @see com.hazelcast.map.impl.operation.EntryOperation#createMapEntry(Data, Object)
*/
public class LazyMapEntry implements Map.Entry, Serializable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Serializable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous class was MapEntrySimple and it was Serializable, preserved same behaviour.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't make any guarantee/promise about serializability of Map.Entry given to the EntryProcessor, I think we can just drop Serializable to make this class simpler.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and created an issue to document it #5611

…-value pairs instead of eager deserialization
@ahmetmircik ahmetmircik force-pushed the enhancement/3.6/entryProcessorUsesLazyMapEntry branch from 584522c to 97acf60 Compare June 26, 2015 11:08
gurbuzali pushed a commit that referenced this pull request Jun 26, 2015
…sorUsesLazyMapEntry

Introduces LazyMapEntry.
@gurbuzali gurbuzali merged commit f82add2 into hazelcast:master Jun 26, 2015
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Internal PR or issue was opened by an employee Team: Core Type: Enhancement
Projects
None yet
4 participants