Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary `CacheLoader` dependency on client and server side at cache proxies #6678

Merged
merged 1 commit into from Nov 9, 2015

Conversation

Projects
None yet
2 participants
@serkan-ozal
Copy link
Contributor

commented Nov 6, 2015

  • Removed unnecessary CacheLoader creation and closing codes at client and server side cache proxies
  • If factory of CacheLoader and CacheWriter is HazelcastInstanceAware, HazelcastInstance is injected
  • Refactor on ClientReadWriteThroughJCacheTests so tests are using mock instances (client and server) and can run with parallel runner.

Fixes #6676

@asimarslan

This comment has been minimized.

Copy link
Member

commented Nov 9, 2015

If TCK pass then 👍

@serkan-ozal

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2015

@asimarslan yes, both of client and server instance based TCK tests pass

serkan-ozal pushed a commit that referenced this pull request Nov 9, 2015

Serkan ÖZAL
Merge pull request #6678 from serkan-ozal/fix/master/issue-6676
Removed unnecessary `CacheLoader` dependency on client and server side at cache proxies

@serkan-ozal serkan-ozal merged commit 2719981 into hazelcast:master Nov 9, 2015

1 check passed

default Build finished. No test results found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.