Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazelcast support for Spring Transaction API #611 #7469

Merged
merged 1 commit into from May 13, 2016

Conversation

Projects
None yet
4 participants
@messo
Copy link
Contributor

commented Feb 5, 2016

An AbstractPlatformTransactionManager implementation called HazelcastTransactionManager is provided with some tests to solve #611. Also there is a TransactionalTaskContext implementation, which can be used to acquire transactional objects (like TransactionalMap) from the context in a spring-way.

@emrahkocaman

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2016

@messo , Thank you very much for your interest and contribution. Let's start reviewing and I hope we can merge it for 3.7.

@messo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2016

Sounds good! I have tried to mimic the way JpaTransactionManager does its magic :) I am open to any suggestion and looking forward to get this into master ;)

@noctarius

This comment has been minimized.

Copy link
Contributor

commented May 10, 2016

@emrahkocaman can you please comment on this PR and see if we can merge it before 3.7 feature freeze? :)

@emrahkocaman

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

verify

@emrahkocaman

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

@messo Thank you very much for your effort. I think, this looks good to be merged.
👍

@emrahkocaman emrahkocaman added this to the 3.7 milestone May 13, 2016

@mesutcelik mesutcelik merged commit e2ead26 into hazelcast:master May 13, 2016

1 check passed

default Build finished. No test results found.
Details
@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

Great work @messo 👏

@emrahkocaman Can you handle documentation and codesamples part?

@messo

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2016

Awesome, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.