Tests newly created recordStores after imap#destroy references same M… #7884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private static final int PARTITION_COUNT = 271; | ||
|
|
||
| @Test | ||
| public void testNewRecordStores_sharesSameMapContainerInstance_afterMapDestroy() throws Exception { |
There was a problem hiding this comment.
could you please describe the scenario this test is checking? it's not very clear from the name as it's a bit ambiguous.
ahmetmircik
force-pushed
the
fix/3.6.3/mapContainerStressTest
branch
from
643ea34
to
e31d310
Compare
…apContainer instance. Normally, we remove mapContainer in map#destroy operation. If we call map#put after map#destroy, a new mapContainer instance is created and all newly created recordStores references that new mapContainer instance. That referenced mapContainer instance should be the new-mapContainer-instance because we previously called map#destroy and removed old mapContainer instance. This test trying to be sure that after map#destroy those all newly created recordStore instances references same single mapContainer instance by stressing mapContainer creation process with subsequent map#put and map#destroy operations.
ahmetmircik
force-pushed
the
fix/3.6.3/mapContainerStressTest
branch
from
e31d310
to
7e78280
Compare
|
Test for the PR: #7838, merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…apContainer
Test for the PR: #7838