Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Wait for proxies to be created before firing a partition lost event #8293

Conversation

Projects
None yet
2 participants
@jerrinot
Copy link
Contributor

commented Jun 2, 2016

Partition proxies are created eventually on all members. However
this is an async process driven by eventing system.

If a member does not have a proxy in its registry then it will
not fire MapPartitionLostListener.

I also removed the assertMapContainerCreated as it served no purpose -

  • MapServiceContext.getMapContainer() has getOrCreateSemantic
    -> the assert was always true.

fixes #7049, backport of #8291

Wait for proxies to be created before firing a partition lost event
Partition proxies are created eventually on all members. However
this is an async process driven by eventing system.

If a member does not have a proxy in its registry then it will
not fire MapPartitionLostListener.

I also removed the assertMapContainerCreated as it served no purpose -
- MapServiceContext.getMapContainer() has getOrCreateSemantic
-> the assert was always true.

cherry picked from commit 7b3e7bd
fixes #7049

@jerrinot jerrinot added this to the 3.6.4 milestone Jun 2, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2016

Test FAILed.

@jerrinot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2016

run-lab-run

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2016

Test FAILed.

@jerrinot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2016

run-lab-run

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2016

Test FAILed.

@jerrinot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2016

run-lab-run

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2016

Test PASSed.

@jerrinot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2016

it's a backport of a test-only change. I'm merging it myself.

@jerrinot jerrinot merged commit eabe324 into hazelcast:maintenance-3.x Jun 3, 2016

1 check passed

default Build finished. 15197 tests run, 182 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.