Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates AsyncAtomicReference. Introduces async methods in IAtomicReference public API. #8580

Conversation

Projects
None yet
5 participants
@vbekiaris
Copy link
Contributor

commented Jul 25, 2016

Async methods in IAtomicReference follow the Async-suffix naming convention; async-prefixed methods will be removed once AsyncAtomicReference is also removed.

@vbekiaris vbekiaris added this to the 3.7 milestone Jul 25, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

Test PASSed.

1 similar comment
@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

Test PASSed.

*
* @param update the new value
* @return the new value
* @deprecated will be removed from Hazelcast 3.4 since it doesn't really serve a purpose.

This comment has been minimized.

Copy link
@jerrinot

jerrinot Jul 25, 2016

Contributor

I appreciate it's a copy-n-paste but the note about removal in 3.4 still looks weird.

This comment has been minimized.

Copy link
@vbekiaris

vbekiaris Jul 25, 2016

Author Contributor

Agreed. Should we just remove it from this PR so it doesn't make it to the public API?

This comment has been minimized.

Copy link
@jerrinot

jerrinot Jul 25, 2016

Contributor

yes
edit: why is it deprecated anywya?

This comment has been minimized.

Copy link
@vbekiaris

vbekiaris Jul 25, 2016

Author Contributor

It is implemented with a get-and-set operation and returns the user-supplied newValue, so I guess it's not a terribly useful method. /cc @pveentjer ?

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

Test PASSed.

@pveentjer

This comment has been minimized.

Copy link
Member

commented Jul 25, 2016

👍

1 similar comment
@tombujok

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2016

👍

@vbekiaris vbekiaris merged commit d26855e into hazelcast:master Jul 26, 2016

1 check passed

default Build finished. 14372 tests run, 175 skipped, 0 failed.
Details

@vbekiaris vbekiaris deleted the vbekiaris:improvements/master/async-atomic-reference branch Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.