Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Fix wrong client defaults when configured via Spring #8761

Conversation

Projects
None yet
4 participants
@jerrinot
Copy link
Contributor

commented Aug 22, 2016

Fix #8746, Backport of #8747
It would be great to just use equals() on the config objects,
however a lot of our *Config(s) do not override equals()/hashcode()
and moreover the config objects are mutated in some cases - e.g.

(cherry picked from commit 939c25c)

Fix wrong client defaults when configured via Spring
Fix #8746
It would be great to  just use equals() on the config objects,
however a lot of our *Config(s) do not override equals()/hashcode()
and moreover the config objects are mutated in some cases - e.g.
  https://github.com/hazelcast/hazelcast/blob/eef987b9920f3f7b4c506e433b0d067cab9ba93c/hazelcast-client/src/main/java/com/hazelcast/client/config/ClientNetworkConfig.java#L207-L207

(cherry picked from commit 939c25c)
@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2016

Test PASSed.

@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2016

👍

@Serdaro ,
Can you please make sure to include this in release notes?

@jerrinot jerrinot merged commit 1dcb1ca into hazelcast:maintenance-3.x Aug 27, 2016

1 check passed

default Build finished. 14446 tests run, 173 skipped, 0 failed.
Details

@jerrinot jerrinot deleted the jerrinot:fixes/spring-config-defaults/maintanance-3.x branch Aug 27, 2016

@Serdaro

This comment has been minimized.

Copy link
Member

commented Aug 29, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.