Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed max-size value in NearCacheConfig #8826

Merged

Conversation

Projects
None yet
3 participants
@Donnerbart
Copy link
Contributor

commented Sep 2, 2016

Fixed max-size value in NearCacheConfig when value was explicitly set to 0. According to the documentation we should set Integer.MAX_VALUE in this case, but it was set to 0.

@Serdaro Please add to the release notes for 3.8, that if you set

<near-cache>
  (...)
  <max-size>0</max-size>
  (...)
</near-cache>

or

NearCacheConfig config = new NearCacheConfig();
config.setMaxSize(0);

that this will set the max-size to Integer.MAX_VALUE now, as expected and documented?

Fixed max-size value in NearCacheConfig
Fixed max-size value in NearCacheConfig when value was explicitly set to 0. According to the documentation we should set Integer.MAX_VALUE in this case, but it was set to 0.

@Donnerbart Donnerbart added this to the 3.8 milestone Sep 2, 2016

@Donnerbart Donnerbart self-assigned this Sep 2, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2016

Test PASSed.

@vbekiaris

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2016

👍 good finding

@Donnerbart Donnerbart merged commit fd9bdc6 into hazelcast:master Sep 2, 2016

1 check passed

default Build finished. 14456 tests run, 174 skipped, 0 failed.
Details

@Donnerbart Donnerbart deleted the Donnerbart:fixNearCacheMaxSizeConfiguration branch Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.