Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] JCache backup operation do not propagate CacheNotExistsException #8955

Conversation

Projects
None yet
3 participants
@jerrinot
Copy link
Contributor

commented Sep 22, 2016

Backport of #8916

Reasoning:

  1. I am a partition owner. You are a backup replica. I execute PUT and send you BACKUP
  2. before you process the BACKUP someone else will tell you to destroy the cache
  3. when you start processing the BACKUP then the cache no longer exists -> exception

New cache creation is blocking a caller until the cache is created on all members
->
if backup operation does not find the cache then it's because it was already destroyed.
not because it wasn't created yet.
->
Skipping the backup when a cache is not found will not lose any item.

(cherry picked from commit 99bd335)

JCache backup operation do not propagate CacheNotExistsException
Reasoning:
1. I am a partition owner. You are a backup replica. I execute PUT and send you BACKUP
2. before you process the BACKUP someone else will tell you to destroy the cache
3. when you start processing the BACKUP then the cache no longer exists -> exception

New cache creation is blocking a caller until the cache is created on all members
->
if backup operation does not find the cache then it's because it was already destroyed.
not because it wasn't created yet.
->
Skipping the backup when a cache is not found will not lose any item.

(cherry picked from commit 99bd335)

@jerrinot jerrinot added this to the 3.7.2 milestone Sep 22, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2016

Test PASSed.

@vbekiaris
Copy link
Contributor

left a comment

👍

@jerrinot jerrinot merged commit 6749a1b into hazelcast:maintenance-3.x Sep 23, 2016

1 check passed

default Build finished. 14451 tests run, 173 skipped, 0 failed.
Details

@jerrinot jerrinot deleted the jerrinot:fixes/jcache-cache-not-found/maintanance-3.x branch Sep 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.