Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BlockingOperation heartbeat problem #8979

Conversation

Projects
None yet
4 participants
@pveentjer
Copy link
Member

commented Sep 26, 2016

The problem is that the WaitingOperation; the container around the BlockingOperation; is
asked for callid/calleraddress. But this container object doesn't have any sensible
information, so the heartbeat is not constructed correctly for a blocked Operation.

Fix BlockingOperation heartbeat problem
The problem is that the ParkedOperation; the container around the BlockingOperation; is
asked for callid/calleraddress. But this container object doesn't have any sensible
information, so the heartbeat is not constructed correctly for a blocked Operation.
for (WaitingOperation op : queue) {
liveOperations.add(op.getCallerAddress(), op.getCallId());
for (WaitingOperation waitingOperation : queue) {
// we need to read out the data from the BlockedOperation; not from the ParkerOperation-container.

This comment has been minimized.

Copy link
@jerrinot

jerrinot Sep 26, 2016

Contributor

a tiny one - the ParkerOperation-container. has a different name in the maintanance branch.

This comment has been minimized.

Copy link
@pveentjer

pveentjer Sep 26, 2016

Author Member

let me do that through a direct push if there are not other comments.

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2016

Test PASSed.

@Donnerbart
Copy link
Contributor

left a comment

Backport of #8977

@Donnerbart Donnerbart added this to the 3.7.2 milestone Sep 26, 2016

@pveentjer pveentjer merged commit 83cdf32 into hazelcast:3.7.2 Sep 26, 2016

1 check passed

default Build finished. 14452 tests run, 173 skipped, 0 failed.
Details

@pveentjer pveentjer deleted the pveentjer:fix/3.7.2/BlockingOperations-heartbeat-failure branch Sep 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.