Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Fix partition replica version handling when backups are reordered #9206

Merged
merged 1 commit into from Nov 28, 2016

Conversation

Projects
None yet
4 participants
@mdogan
Copy link
Member

commented Oct 31, 2016

When backups are reordered and a backup with a version greater than (localVersion + 1)
is received, backup is applied but partition replica versions are not updated. After that point, until replica is repaired, succeeding stale backups cannot be detected
anymore. This breaks monotonicity of backups.

Now, partition replica versions are always updated when (newVersion > localVersion) but
partition is marked as dirty if (newVersion > localVersion + 1). Anti-entropy system will take
this dirty flag into account too.

Backport of #9205

@mdogan mdogan added this to the 3.7.3 milestone Oct 31, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2016

Test PASSed.

Fix partition replica version handling when backups are reordered
When backups are reordered and a backup with a version greater than (localVersion + 1)
is received it's applied but partition replica versions are not updated
. After that point, until replica is repaired, succeeding stale backups cannot be detected
anymore. This breaks monotonicity of backups.

Now, partition replica versions are always updated when (newVersion > localVersion) but
partition is marked as dirty if (newVersion > localVersion + 1). Anti-entropy system will take
this dirty flag into account too.

@mdogan mdogan force-pushed the mdogan:partition-dirty-x branch from ce381ab to 402fdb7 Nov 1, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2016

Test PASSed.

@ihsandemir ihsandemir modified the milestones: 3.7.4, 3.7.3 Nov 1, 2016

@metanet metanet changed the title Fix partition replica version handling when backups are reordered [BACKPORT] Fix partition replica version handling when backups are reordered Nov 28, 2016

@metanet metanet merged commit 2af0e35 into hazelcast:maintenance-3.x Nov 28, 2016

1 check passed

default Build finished. 14478 tests run, 178 skipped, 0 failed.
Details

@mdogan mdogan deleted the mdogan:partition-dirty-x branch Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.