Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Partitions should remain unavailable until services commit/rollback #9235

Merged
merged 1 commit into from Nov 28, 2016

Conversation

Projects
None yet
3 participants
@mdogan
Copy link
Member

commented Nov 10, 2016

Partitions should be unavailable/inaccessible until MigrationAwareServices
complete commit/rollback during migration and/or promotion.
Each partition has an isMigrating flag which is set before migration starts
and cleared after migration completes. When a partition is marked as migrating,
partition operations will be rejected immediately.

This fix provides safety by guaranteeing an operation which is submitted after
migration-start, won't be executed before MigrationAwareService commit/rollback-return.

Backport of #9234

@mdogan mdogan added this to the 3.7.4 milestone Nov 10, 2016

@metanet metanet changed the title Partitions should remain unavailable until services commit/rollback [BACKPORT] Partitions should remain unavailable until services commit/rollback Nov 10, 2016

@metanet

This comment has been minimized.

Copy link
Contributor

commented Nov 10, 2016

👍

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 10, 2016

Test PASSed.

Partitions should remain unavailable until services commit/rollback
Partitions should be unavailable/inaccessible until `MigrationAwareService`s
complete commit/rollback during migration and/or promotion.
Each partition has an `isMigrating` flag which is set before migration starts
and cleared after migration completes. When a partition is marked as migrating,
partition operations will be rejected immediately.

This fix provides safety by guaranteeing an operation which is submitted after
migration starts, won't be executed before MigrationAwareService commit/rollback returns.

@mdogan mdogan force-pushed the mdogan:migration-commit-safety-x branch from 290403c to 9660bca Nov 10, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 10, 2016

Test PASSed.

@metanet metanet merged commit 4c22ed7 into hazelcast:maintenance-3.x Nov 28, 2016

1 check passed

default Build finished.
Details

@mdogan mdogan deleted the mdogan:migration-commit-safety-x branch Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.