Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6 BACKPORT] Do not change keyLoaderState when loading keys supplied by user #9279

Conversation

Projects
None yet
2 participants
@jerrinot
Copy link
Contributor

commented Nov 21, 2016

The LoadAllOperation is used in 2 contexts:

  1. loadAll() - when all entries are reloaded
  2. loadAll(keys) - when reload of specific keys is requested by user

The first case uses a complex key-loading coordination and state transitions,
while the 2nd case is fairly simple - every member receives a set of keys
directly from the user.

This changeset fix the behaviour in the 2nd case where the
state was changed by accident and this led to a buggy
behaviour.

Fixes #9255 in the 3.6. line.
(cherry picked from commit 4614c94)

EE Part: hazelcast/hazelcast-enterprise#1139

Do not change keyLoaderState when loading keys supplied by user
The LoadAllOperation is used in 2 contexts:
1. loadAll() - when all entries are reloaded
2. loadAll(keys) - when reload of specific keys is requested by user

The first case uses a complex key-loading coordination and state transitions,
while the 2nd case is fairly simple - every member receives a set of keys
directly from the user.

This changeset fix the behaviour in the 2nd case where the
state was changed by accident and this led to a buggy
behaviour.

Fixes #9255
(cherry picked from commit 4614c94)

@jerrinot jerrinot added this to the 3.6.7 milestone Nov 21, 2016

@jerrinot jerrinot changed the title [BACKPORT] Do not change keyLoaderState when loading keys supplied by user [3.6 BACKPORT] Do not change keyLoaderState when loading keys supplied by user Nov 21, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2016

Test PASSed.

@jerrinot jerrinot merged commit ac1e474 into hazelcast:3.6.7 Nov 21, 2016

1 check passed

default Build finished.
Details
@jerrinot

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2016

merging myself as ports to other branches are already merged.

@jerrinot jerrinot deleted the jerrinot:fixes/load-all-keys-field-piggy-backbacking/3.6.7 branch Nov 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.