Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport https://github.com/hazelcast/hazelcast/pull/9273 #9282

Merged

Conversation

Projects
None yet
2 participants
@ihsandemir
Copy link
Contributor

commented Nov 21, 2016

Backports #9273

Reverted some of the the changes that was done as part of listener registration fix in terms of endpoint management. I previously changed to reuse the same endpoint for the reconnecting client in order to make the old existing listener be able to deliver the event messages to the same client that was reconnected (Doing this in AbstractBaseTask.sendClientMessage).

Also, added a reason to be printed when the endpoint is being destroyed. Since, this is an internal interface, I am hoping that this won't be a problem.

@ihsandemir ihsandemir added this to the 3.7.4 milestone Nov 21, 2016

@ihsandemir ihsandemir self-assigned this Nov 21, 2016

@devOpsHazelcast

This comment has been minimized.

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 24, 2016

Test PASSed.

ihsandemir added some commits Nov 21, 2016

Backports #9273
Reverted some of the the changes that was done as part of listener registration fix in terms of endpoint management. I previously changed to reuse the same endpoint for the reconnecting client in order to make the old existing listener be able to deliver the event messages to the same client that was reconnected (Doing this in AbstractBaseTask.sendClientMessage).

Also, added a reason to be printed when the endpoint is being destroyed. Since, this is an internal interface, I am hoping that this won't be a problem.

@ihsandemir ihsandemir force-pushed the ihsandemir:maint/backports/PR9273 branch from b1a2363 to 97265e0 Nov 24, 2016

@devOpsHazelcast

This comment has been minimized.

@devOpsHazelcast

This comment has been minimized.

@ihsandemir

This comment has been minimized.

Copy link
Contributor Author

commented Nov 24, 2016

run-lab-run

@devOpsHazelcast

This comment has been minimized.

@ihsandemir

This comment has been minimized.

Copy link
Contributor Author

commented Nov 24, 2016

run-lab-run

@devOpsHazelcast

This comment has been minimized.

@ihsandemir

This comment has been minimized.

Copy link
Contributor Author

commented Nov 24, 2016

run-lab-run

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 24, 2016

Test PASSed.

@ihsandemir ihsandemir merged commit 0582486 into hazelcast:maintenance-3.x Nov 24, 2016

1 check passed

default Build finished.
Details

@ihsandemir ihsandemir deleted the ihsandemir:maint/backports/PR9273 branch Nov 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.