Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invocation lastHeartbeatMillis reset in case of retry #9287

Conversation

Projects
None yet
4 participants
@pveentjer
Copy link
Member

commented Nov 21, 2016

In case of a retrying operation, an old heartbeat could still be stored
on the invocation. If the invocation monitor sees this; it currently doesn't
understand that this from an old invocation; it will just conclude that the
invocation has not received any recent heartbeats and will abort the invocation
with an OperationTimeoutException.

This pr fixes that by resetting the lastHeartbeat when the invocation is retried.

backport of #9286

@pveentjer pveentjer added this to the 3.7.4 milestone Nov 21, 2016

@pveentjer pveentjer changed the title In case of a retrying operation, an old heartbeat could still be stored Invocation lastHeartbeatMillis reset in case of retry Nov 21, 2016

@Donnerbart
Copy link
Contributor

left a comment

What is the second file in this PR? An empty PID file?

@pveentjer

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2016

I'll remove it. No idea what it is. Apart from this file; you are fine with the PR?

@Donnerbart

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2016

Yes, otherwise it seems to be a proper 1:1 backport.

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2016

Test PASSed.

In case of a retrying operation, an old heartbeat could still be stored
on the invocation. If the invocation monitor sees this; it currently doesn't
understand that this from an old invocation; it will just conclude that the
invocation has not received any recent heartbeats and will abort the invocation
with an OperationTimeoutException.

This pr fixes that by resetting the lastHeartbeat when the invocation is retried.

@pveentjer pveentjer force-pushed the pveentjer:fix/3.7/invocation-lastheartbeatreceived-reset branch from 558f5f8 to ce12461 Nov 21, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2016

Test PASSed.

@pveentjer pveentjer merged commit 7968ebb into hazelcast:maintenance-3.x Nov 22, 2016

1 check passed

default Build finished.
Details

@pveentjer pveentjer deleted the pveentjer:fix/3.7/invocation-lastheartbeatreceived-reset branch Nov 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.