Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with MockConnectionManager.stop when nodes stopped concurrently #9324

Merged
merged 1 commit into from Nov 28, 2016

Conversation

Projects
None yet
2 participants
@mdogan
Copy link
Member

commented Nov 25, 2016

When nodes terminates concurrently, clusterService.removeAddress can fail because
target node is already shutdown.

This issue is introduced by #9311

@mdogan mdogan added this to the 3.7.4 milestone Nov 25, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2016

Test FAILed.
https://hazelcast-l337.ci.cloudbees.com/job/new-lab-fast-pr/5919/

ListItemListenerOnReconnectTest.testClusterReconnectDueToHeartbeatNonSmartRouting

@mdogan

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2016

run-lab-run

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2016

Test FAILed.
https://hazelcast-l337.ci.cloudbees.com/job/new-lab-fast-pr/5922/

EntryListenerOnReconnectTest.testClusterReconnectMultipleServersDueToHeartbeatSmartRouting

@mdogan

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2016

run-lab-run

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2016

Test PASSed.

Fix issue with MockConnectionManager.stop when nodes stopped concurre…
…ntly

When nodes terminates concurrently, `clusterService.removeAddress` can fail because
target node is already shutdown.

This issue is introduced by #9311

@mdogan mdogan force-pushed the mdogan:mock-stop-fix2-x branch from 5384e7e to beed58d Nov 28, 2016

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2016

Test PASSed.

@mdogan

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2016

Original is merged already: #9323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.