Clean up quorum implementation #9552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metanet
force-pushed
the
fix/master/8820
branch
from
bf9e13d
to
8952e3d
Compare
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
metanet
force-pushed
the
fix/master/8820
branch
3 times, most recently
from
cd56f77
to
164ea8c
Compare
mdogan
approved these changes
Dec 30, 2016
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
|
run-lab-run |
metanet
force-pushed
the
fix/master/8820
branch
from
164ea8c
to
a636bc1
Compare
Otherwise, membership aware services are not be initialized yet and they will not capture the initial membership event.
metanet
force-pushed
the
fix/master/8820
branch
from
a636bc1
to
d6e1b7c
Compare
|
run-lab-run |
* Once initial membership event dispatching is fixed, initialized flag is not needed in QuorumImpl. * Instead of a boolean flag, quorum state is managed with an enum value and it is initialized properly. * If user-provided quorum function fails during membership update, quorum status is force-set to ABSENT and the failure is logged.
metanet
force-pushed
the
fix/master/8820
branch
from
d6e1b7c
to
ac4741b
Compare
eminn
approved these changes
Jan 3, 2017
|
Test PASSed. |
|
Since there are 2 thumbs up, I'm hitting the merge button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit messages for further details.
Fixes #8820