Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration sanity check #1

Closed
dennybritz opened this issue Mar 24, 2014 · 2 comments · Fixed by #445
Closed

Configuration sanity check #1

dennybritz opened this issue Mar 24, 2014 · 2 comments · Fixed by #445
Assignees

Comments

@dennybritz
Copy link
Contributor

We should do a sanity check on the configuration upon loading. Instead of the application crashing in the middle of execution due to a configuration issue, we should immediately exit if we find an obvious mistake. Some things we can check for:

  • Does the schema match the variables used in factor functions?
  • Do all extractor UDF files exist?
  • Do all extractor output relations exist?

There probably are more things that we can check for.

@rionda
Copy link
Contributor

rionda commented Nov 21, 2014

Zifei, this is an interesting idea if you would like to work on it.
Note that the active pipeline should be taken into account when doing the above checks.

@zifeishan
Copy link
Contributor

Last time I made a typo in "calibration.holdout_query" and the system just did not holdout anything... We need this sanity check!

netj added a commit that referenced this issue Dec 16, 2015
Fixes #349.
Sets up a modular checker structure for easily adding more checks, e.g.,
for test firing UDFs (#1).  See TODOs in deepdive-compile for more
checks that should be added.
netj added a commit that referenced this issue Dec 16, 2015
Fixes #349.
Sets up a modular checker structure for easily adding more checks, e.g.,
for test firing UDFs (#1).  See TODOs in deepdive-compile for more
checks that should be added.
netj added a commit that referenced this issue Dec 16, 2015
Fixes #349.
Sets up a modular checker structure for easily adding more checks, e.g.,
for test firing UDFs (#1).  See TODOs in deepdive-compile for more
checks that should be added.
netj added a commit that referenced this issue Dec 16, 2015
Fixes #349.
Sets up a modular checker structure for easily adding more checks, e.g.,
for test firing UDFs (#1).  See TODOs in deepdive-compile for more
checks that should be added.
@netj netj added this to the DeepDive 0.8.0 milestone Dec 17, 2015
netj pushed a commit that referenced this issue Jan 23, 2017
netj pushed a commit that referenced this issue Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants