Python extension #32
Merged
Python extension #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbf
approved these changes
Jan 22, 2022
There was a problem hiding this comment.
@adamheins Thanks for the contribution! Great catch also spotting and removing unnecessary Python dependencies.
python/setup.py
Outdated
| version="1.0", | ||
| description="Library to find the smallest enclosing ball of points", | ||
| author="Martin Kutz", | ||
| author_email="kutz@math.fu-berlin.de", |
There was a problem hiding this comment.
Can you change the author to Kaspar Fischer, Bernd Gärtner, and Martin Kutz; as for the email, Martin Kutz is sadly not with us anymore so I suggest to remove it (the URL points to this GitHub project, which should be a good way to get help).
FYI I switched the project settings to only offer “Squash and merge”. |
|
Thanks again. Happy to add you also to the README if you’d like that, feel free to make a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for changing the Python bindings such that they're written as a C++ extension, one benefit of which is that it can be installed in the usual way with
python setup.py install(and thus can be readily included in other projects without copying code). I've matched the API from the original implementation, and the tests are the same except for the type of exception raised for passing the wrong argument.Let me know if you think this would be a useful change. I'm happy to make any changes to this code, and if we decide to go forward with this PR I can clean up the commit history before merging.