-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tx_power in advertisement_data for Windows, Mac and Linux #987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have made a few suggestions.
CHANGELOG.rst
Outdated
@@ -19,6 +19,8 @@ Changed | |||
* The BlueZ D-Bus backend implements a services cache between connections to significancy improve reconnect performance. | |||
To use the cache, call ``connect`` and ``get_services`` with the ``dangerous_use_bleak_cache`` | |||
argument to avoid services being resolved again. | |||
* ``AdvertisementData`` class now has an attribute ``tx_power``. scanner.py in backends of winrt, corebluetooth and | |||
bluezdbus were changed to set tx_power if available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this for the Android backend too (even if you aren't able to test it)?
i.e. use result.getTxPower()
in _PythonScanCallback.onScanResult()
.
It also looks like we might want to convert ScanResult.TX_POWER_NOT_PRESENT
to None
to be consistent with other backends.
https://developer.android.com/reference/android/bluetooth/le/ScanResult#getTxPower()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Actually now I have Android Studio but don't have test environment Android (will come in 2 weeks). So this time I made changes and test them later (if necessary). Thank you for your advice.
Co-authored-by: David Lechner <david@lechnology.com>
Co-authored-by: David Lechner <david@lechnology.com>
Co-authored-by: David Lechner <david@lechnology.com>
Co-authored-by: David Lechner <david@lechnology.com>
Merged, thanks! |
Pull Request Guidelines for Bleak
Before you submit a pull request, check that it meets these guidelines:
CHANGELOG.rst
, describing your changes as is specified by theguidelines in that document.
different problems and you are committing them in the same PR. In that case,
consider making several PRs instead.
AUTHORS.rst
file!