Added tx_power in advertisement_data for Windows, Mac and Linux #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
requested changes
Sep 8, 2022
CHANGELOG.rst
Outdated
| @@ -19,6 +19,8 @@ Changed | |||
| * The BlueZ D-Bus backend implements a services cache between connections to significancy improve reconnect performance. | |||
| To use the cache, call ``connect`` and ``get_services`` with the ``dangerous_use_bleak_cache`` | |||
| argument to avoid services being resolved again. | |||
| * ``AdvertisementData`` class now has an attribute ``tx_power``. scanner.py in backends of winrt, corebluetooth and | |||
| bluezdbus were changed to set tx_power if available. | |||
There was a problem hiding this comment.
Can we get this for the Android backend too (even if you aren't able to test it)?
i.e. use result.getTxPower() in _PythonScanCallback.onScanResult().
It also looks like we might want to convert ScanResult.TX_POWER_NOT_PRESENT to None to be consistent with other backends.
https://developer.android.com/reference/android/bluetooth/le/ScanResult#getTxPower()
There was a problem hiding this comment.
Yes. Actually now I have Android Studio but don't have test environment Android (will come in 2 weeks). So this time I made changes and test them later (if necessary). Thank you for your advice.
Co-authored-by: David Lechner <david@lechnology.com>
Co-authored-by: David Lechner <david@lechnology.com>
Co-authored-by: David Lechner <david@lechnology.com>
dlech
reviewed
Sep 9, 2022
Co-authored-by: David Lechner <david@lechnology.com>
dlech
approved these changes
Sep 11, 2022
|
Merged, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines for Bleak
Before you submit a pull request, check that it meets these guidelines:
CHANGELOG.rst, describing your changes as is specified by theguidelines in that document.
different problems and you are committing them in the same PR. In that case,
consider making several PRs instead.
AUTHORS.rstfile!