Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Algorithm const definitions #2

Merged
merged 1 commit into from Nov 10, 2020
Merged

Simplify Algorithm const definitions #2

merged 1 commit into from Nov 10, 2020

Conversation

shogg
Copy link
Contributor

@shogg shogg commented Nov 9, 2020

Just shorter code, semantically the same. Tests passed.

@shogg
Copy link
Contributor Author

shogg commented Nov 9, 2020

You should do something about your slow tests. Perhaps disable them on Travis. You can check for TRAVIS environment variable to be present.

@hbollon
Copy link
Owner

hbollon commented Nov 10, 2020

Thanks for your refactor ! 👍
For the testing part what can I do to speed up them? I can't remove them from Travis for obvious reasons of CI and for CodeCov results.

@hbollon hbollon added the enhancement New feature or request label Nov 10, 2020
@hbollon hbollon merged commit a86cf3b into hbollon:master Nov 10, 2020
@hbollon
Copy link
Owner

hbollon commented Nov 10, 2020

Ok so I experienced this unusually long build time with Travis.
This is due to their waiting queue,I did some research and it looks like that Travis has been having issues on their end for a few days. I'll see if this resolves in the next few days and advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shogg @hbollon