config: Remove duplicate folders in the rare case they happen. Closes #…

…978
hbons · Sep 21, 2012 · f5b7920 · f5b7920
1 parent 448d1b4
commit f5b7920
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/SparkleLib/SparkleConfig.cs b/SparkleLib/SparkleConfig.cs
@@ -169,6 +169,8 @@ private void CreateInitialConfig ()
                 foreach (XmlNode node_folder in SelectNodes ("/sparkleshare/folder"))
                     folders.Add (node_folder ["name"].InnerText);
 
+                folders.Sort ();
+
                 return folders;
             }
         }

diff --git a/SparkleShare/SparkleControllerBase.cs b/SparkleShare/SparkleControllerBase.cs
@@ -90,8 +90,6 @@ public abstract class SparkleControllerBase {
         public List<string> Folders {
             get {
                 List<string> folders = this.config.Folders;
-                folders.Sort ();
-
                 return folders;
             }
         }
@@ -313,6 +311,7 @@ private void CheckRepositories ()
             lock (this.check_repos_lock) {
                 string path = this.config.FoldersPath;
 
+                // Detect any renames
                 foreach (string folder_path in Directory.GetDirectories (path)) {
                     string folder_name = Path.GetFileName (folder_path);
 
@@ -340,21 +339,30 @@ private void CheckRepositories ()
                     }
                 }
 
+                // Remove any deleted folders
                 foreach (string folder_name in this.config.Folders) {
                     string folder_path = new SparkleFolder (folder_name).FullPath;
 
                     if (!Directory.Exists (folder_path)) {
                         this.config.RemoveFolder (folder_name);
                         RemoveRepository (folder_path);
 
-                        SparkleLogger.LogInfo ("Controller",
-                            "Removed folder '" + folder_name + "' from config");
+                        SparkleLogger.LogInfo ("Controller", "Removed folder '" + folder_name + "' from config");
 
                     } else {
                         AddRepository (folder_path);
                     }
                 }
 
+                // Remove any duplicate folders
+                string previous_name = "";
+                foreach (string folder_name in this.config.Folders) {
+                    if (!string.IsNullOrEmpty (previous_name) && folder_name.Equals (previous_name))
+                        this.config.RemoveFolder (folder_name);
+                    else
+                        previous_name = folder_name;
+                }
+
                 FolderListChanged ();
             }
         }