Create an Explorer folder icon #648

Closed
spisoft opened this Issue Mar 19, 2012 · 12 comments

Comments

Projects
None yet
5 participants
@spisoft

spisoft commented Mar 19, 2012

i see my link in the favourites bar, but the icon of the folder is a normal one because in the sparkleshare folder there is no desktop.ini (see #624 )
i am missing the link in the autostart folder too and i have a little feature request

would it be possible to add the icon to add/remove programms ?
it is just one line for wix to add:
<Icon Id="icon.ico" SourceFile="MySourceFiles\icon.ico"/>
<Property Id="ARPPRODUCTICON" Value="icon.ico" />

-> http://wix.sourceforge.net/manual-wix3/configure_arp_appearance.htm

@hbons

This comment has been minimized.

Show comment Hide comment
@hbons

hbons Mar 20, 2012

Owner

The annoying thing here is that we can't just change Windows's icons, as i'm guessing they won't be compatible with the GPL. We'll need to find some other icons that are similar in style to the Windows 7 folder icons but that we can ship.

Owner

hbons commented Mar 20, 2012

The annoying thing here is that we can't just change Windows's icons, as i'm guessing they won't be compatible with the GPL. We'll need to find some other icons that are similar in style to the Windows 7 folder icons but that we can ship.

@spisoft

This comment has been minimized.

Show comment Hide comment
@spisoft

spisoft Mar 21, 2012

so you don't want to replace the folder icon with the existing sparkleshare icon but change icons dynamically like DropBox does ?
When i am right, we should have a look to TurtoiseSvn or TutroiseGit, because they have the same behaviour and are GPL. I searched through the coude of TurtoiseSvn and found a c++ class that modifies the existing icons IconOverlay.cpp
Maybe it is possible to change icons with c# too.

Code can be found here:
TortoiseSvn
TortoiseGit

spisoft commented Mar 21, 2012

so you don't want to replace the folder icon with the existing sparkleshare icon but change icons dynamically like DropBox does ?
When i am right, we should have a look to TurtoiseSvn or TutroiseGit, because they have the same behaviour and are GPL. I searched through the coude of TurtoiseSvn and found a c++ class that modifies the existing icons IconOverlay.cpp
Maybe it is possible to change icons with c# too.

Code can be found here:
TortoiseSvn
TortoiseGit

@kvaggelakos

This comment has been minimized.

Show comment Hide comment
@kvaggelakos

kvaggelakos Mar 21, 2012

Contributor

Looked into this a bit. Seems like it is hard to do in C# and easier to do in C++. Following links have examples of how to do this:

Contributor

kvaggelakos commented Mar 21, 2012

Looked into this a bit. Seems like it is hard to do in C# and easier to do in C++. Following links have examples of how to do this:

@hbons

This comment has been minimized.

Show comment Hide comment
@hbons

hbons Mar 21, 2012

Owner

This is just about the orange sparkleshare folder icon. The overlay badges are handled by #389. But thanks for the links!

We somehow need to grab the existing Windows folder icons and change the hue in memory. or something like that.

Owner

hbons commented Mar 21, 2012

This is just about the orange sparkleshare folder icon. The overlay badges are handled by #389. But thanks for the links!

We somehow need to grab the existing Windows folder icons and change the hue in memory. or something like that.

@kvaggelakos

This comment has been minimized.

Show comment Hide comment
@kvaggelakos

kvaggelakos Mar 21, 2012

Contributor

Alright then I have two new questions:

Sorry for the misunderstanding and my incompetence in the subject

Contributor

kvaggelakos commented Mar 21, 2012

Alright then I have two new questions:

Sorry for the misunderstanding and my incompetence in the subject

@hbons

This comment has been minimized.

Show comment Hide comment
@hbons

hbons Mar 21, 2012

Owner

@kozze89 yes, setting the icon to the folder is pretty easy. The problem is that the folder icons can probably not be relicensed under the GPL, making SparkelShare partly not open source.

Owner

hbons commented Mar 21, 2012

@kozze89 yes, setting the icon to the folder is pretty easy. The problem is that the folder icons can probably not be relicensed under the GPL, making SparkelShare partly not open source.

@aderouineau

This comment has been minimized.

Show comment Hide comment
@aderouineau

aderouineau May 4, 2012

I'm not sure how adding this feature (and applying the "fix" the original poster suggested) would threaten the GPL. If the SparkleShare folder icon is opensource, that should be enough.

I'm not sure how adding this feature (and applying the "fix" the original poster suggested) would threaten the GPL. If the SparkleShare folder icon is opensource, that should be enough.

@hbons

This comment has been minimized.

Show comment Hide comment
@hbons

hbons May 4, 2012

Owner

@aderouineau it would infringe on MS's copyright for the folder images and, as far as i know, they haven't released those folder images in a GPLv3 compatible manner.

Owner

hbons commented May 4, 2012

@aderouineau it would infringe on MS's copyright for the folder images and, as far as i know, they haven't released those folder images in a GPLv3 compatible manner.

@alexschomb

This comment has been minimized.

Show comment Hide comment
@alexschomb

alexschomb May 24, 2012

Well, how about an extra utility that offers this behaviour and won't be licensed under GPLv3 but still Open Source? You might want to recommend using that tool in the installer or on the webpage.

Well, how about an extra utility that offers this behaviour and won't be licensed under GPLv3 but still Open Source? You might want to recommend using that tool in the installer or on the webpage.

@hbons

This comment has been minimized.

Show comment Hide comment
@hbons

hbons May 24, 2012

Owner

@alexschomb it's not about the GPL in particular, you can pretty much replace "GPL" with "Open Source" in my comment. Having a separate utility also kind of misses the point of having a nice an integrated application.

Owner

hbons commented May 24, 2012

@alexschomb it's not about the GPL in particular, you can pretty much replace "GPL" with "Open Source" in my comment. Having a separate utility also kind of misses the point of having a nice an integrated application.

@alexschomb

This comment has been minimized.

Show comment Hide comment
@alexschomb

alexschomb May 24, 2012

Well, too bad. But isn't it better having a separate utility instead of nothing?

Well, too bad. But isn't it better having a separate utility instead of nothing?

@hbons

This comment has been minimized.

Show comment Hide comment
@hbons

hbons May 24, 2012

Owner

I disagree... I'd rather do it properly, but you are free to create such utility of course. :)
If anyone is able to help doing the in memory manipulation of the Windows folder icon that would be great.

Owner

hbons commented May 24, 2012

I disagree... I'd rather do it properly, but you are free to create such utility of course. :)
If anyone is able to help doing the in memory manipulation of the Windows folder icon that would be great.

@hbons hbons closed this in 1469a14 Jul 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment