Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Jan 21, 2010
  1. Removed fully-qualifieid name.

    hborders authored
Commits on Dec 28, 2009
  1. Fixed bug in -to -by. Application is complete.

    hborders authored
Commits on Dec 27, 2009
  1. Added 2 more integration tests. Found a bug in -to -by. Still don't h…

    hborders authored
    …ave it working right.
Commits on Dec 26, 2009
  1. Can't use the console because when Eclipse launches, it doesn't get a…

    hborders authored
    … console. Using a console shows no difference on the bash command line.
  2. Added another integration test. Converted to use Readers and Writers …

    hborders authored
    …so that a Console could be used. The console properly moves the cursor.
  3. Created integration tests. Just need to write two more. My bug was th…

    hborders authored
    …at I wasn't flushing the writer.
  4. Removed all convenience constructors except for RockPaperScissors. Pr…

    hborders authored
    …oviders galore!`
  5. Theoretically completed the app. Need integration tests because it do…

    hborders authored
    …es not work. :(
    
    GameCount could not be removed.  It abstracted the notion of a positive number.  Renamed it to RoundCount since it was really a count of the rounds won not of games won.
  6. Implemented -to and -to -by. Just need to implement factories that wi…

    hborders authored
    …ll create WonRoundCounts from GameCounts. I suspect I'll be able to get rid of the GameCounts entirely, and just use WonRoundCounts.
  7. Implemented and tested DefaultGameFactory.

    hborders authored
  8. Implemented -to -by game. This required added a hook to the Round to …

    hborders authored
    …add code after the Round had been played. This could also have been added to the Game, but it was simpler to add to the Round since the Game has so many conditions inside its play method. This ended up removing the need to distinguish between types of Games, which eliminated 2 classes.
Commits on Dec 25, 2009
  1. Created classes for all tracked counts: won rounds, bestof games, and…

    hborders authored
    … to-by games. This greatly helps with mocking. Moved mutability from Player into WonRoundCount. This makes sense since the number of rounds won is the only thing in a Game that can change.
    
    Removed unneeded interfaces/abstract classes.
    
    I'm beginning to question the cost of refactoring.
Commits on Dec 24, 2009
  1. Rounds no longer must be created before the are played. A round now i…

    hborders authored
    …s simply the logic of playing a round, not the logic and result. Thus, a Round object can be played many times.
  2. Implemented BestofGameFactory. As predicted, the Round Provider and A…

    hborders authored
    …ttemptReader had to move all the way up to the BestofGameFactoryFactory.
  3. Tested Bestof

    hborders authored
  4. Moved won game count into the player to avoid an annoying if statemen…

    hborders authored
    …t caused by original API. Prviously, I would have to check which player the round returned and increment a count in the game. now, I can just increment the count from within the round.
  5. Created test to validate that the BestofGameFactory throws an excepti…

    hborders authored
    …on when the gameCount is even. Propagated tests upwards to guarantee that the Exception is handled properly. Still haven't implemented BestofGame.
  6. Changed GameCount.Provider to be a string to int converter. Discovere…

    hborders authored
    …d during creation of BestofGame that I need to validate that a Bestof game has an odd number of games. Just wrote tests, no impls.
  7. Implemented previous tests. IOException from reading and writing prop…

    hborders authored
    …agated up to Round and will probably go all the way to RockPaperScissors.
  8. Created tests for AttemptFactory and AttemptReader. Split responsibil…

    hborders authored
    …ity for creating and reading input into AttemptReader. AttemptFactory converts a String to an Attempt.
  9. Created all tests for AttemptFactory. Need to refactor to remove dupl…

    hborders authored
    …ication. The Attempt should be in charge of String-to-Attempt conversion.
  10. Moved playerNumber into Player so that the playerNumber can be printe…

    hborders authored
    …d with the player name.
Commits on Dec 23, 2009
  1. Added player numbers to the AttemptFactory so that when querying for …

    hborders authored
    …an attempt, you can specify the player number in addition to the player name.
  2. Implemented writing a Player to a Writer`

    hborders authored
  3. Added Tests and API for writing a player to a writer. This is needed …

    hborders authored
    …to write whose turn it is.
  4. Enums cannot be mocked. Mocking is more important.

    hborders authored
    Revert "Changed Attempt to be an enum.  This reduced the number of tests to write.  This also will push input-to-Attempt creation logic into the factory."
    
    This reverts commit 3086795.
  5. Changed Attempt to be an enum. This reduced the number of tests to wr…

    hborders authored
    …ite. This also will push input-to-Attempt creation logic into the factory.
  6. Created API and tests around individual attempts. These will be the b…

    hborders authored
    …asic data object of the app.
  7. Apparently, it is bad news to ammend a commit after pushing it to ano…

    hborders authored
    …ther repo.
    
    Merge branch 'master' of github.com:hborders/RockPaperScissors
    
    Conflicts:
    	RockPaperScissors/src/com/github/hborders/rockpaperscissors/BestofGame.java
    	RockPaperScissors/src/com/github/hborders/rockpaperscissors/BestofGameFactory.java
    	RockPaperScissors/src/com/github/hborders/rockpaperscissors/DefaultGameFactory.java
    	RockPaperScissors/src/com/github/hborders/rockpaperscissors/IGameFactory.java
    	RockPaperScissors/src/com/github/hborders/rockpaperscissors/ToByGame.java
    	RockPaperScissors/src/com/github/hborders/rockpaperscissors/ToByGameFactory.java
    	RockPaperScissors/src/com/github/hborders/rockpaperscissors/ToGameFactory.java
    	RockPaperScissors/test/com/github/hborders/rockpaperscissors/RockPaperScissorsTest.java
  8. Implemented round.

    hborders authored
  9. Created tests and API for an individual round of the game. Slightly o…

    hborders authored
    …verspecified because I'm guessing I'll need a Console.
Something went wrong with that request. Please try again.