Lowercased SourceLocation

[MassimoSporchia]

Hello,

is there a particular reason to have the SourceLocation lowercased?

In particular in these two situations:

puppet-powershellmodule/lib/puppet/type/psrepository.rb

Line 30 in a91a6d4

munge(&:downcase)

and

puppet-powershellmodule/lib/puppet/provider/psrepository/powershellcore.rb

Line 73 in a91a6d4

'source_location' = $_.SourceLocation.ToLower()

Since I think most of the webserver out there doesn't rewrite urls (e.g. Nexus Sonatype doesn't do it), I was wondering if removing these parameter alteration would be a thing.

[hbuckle]

Hi - this is just an internal thing to make it easier to compare strings. Although URLs aren't case sensitive, Puppet is so if the casing were different Puppet would think it needed to be changed. It should have no effect on actually interacting with repos.

[MassimoSporchia]

It does affect the interaction with repos, this code for example doesn't work with the lowercase:

psrepository { 'PSGalleryProxy':
    ensure              => present,
    source_location     => 'http://mylocalnexus/repository/PowerShellGallery_proxy/',
    installation_policy => 'untrusted',
    provider            => 'windowspowershell',
  }

Since a call to "http://mylocalnexus/repository/PowerShellGallery_proxy/" returns 200, a call to "http://mylocalnexus/repository/powershellgallery_proxy/" returns 404 so the Set-PSRepository command returns malformed URL

[hbuckle]

Ah ok, I didn't know that some servers treated the URL as case sensitive. I should be able to update this to remove the lower casing.

[MassimoSporchia]

I've got minimal modification in my current workspace, if you want I'll make a pull request :)
(which basically removes the lowercasing lines I've put in the issue, by the way) but I'm guessing there is much more than those 2 lines

[hbuckle]

2.0.0 makes source location case sensitive