(MODULES-6699) Add spec tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the gitignore file to account for the most common files ignored in Puppet modules
This commit adds unit tests for the psrepository type
jpogran
changed the title
This commit updates the psrepository type validation to provide basic guards for the params and properties.
jpogran
changed the title
|
Hi @hbuckle, I was hoping you could review this for me. This is part of our work to get this module to the approved status. |
RandomNoun7
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds spec tests to cover the
psrepositorytype, then increases the validation blocks in thepsrepositorytype to handle basic validation for params and properties.It also updates the .gitignore to ignore the common files generated in Puppet module development.