Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust hasGeometry structure #101

Closed
acka47 opened this issue May 9, 2018 · 4 comments
Closed

Adjust hasGeometry structure #101

acka47 opened this issue May 9, 2018 · 4 comments

Comments

@acka47
Copy link
Contributor

@acka47 acka47 commented May 9, 2018

A current example http://lobid.org/gnd/4210884-6.json:

{
  "id": "http://d-nb.info/gnd/4210884-6",
  "hasGeometry":[
    {
      "type":"Point",
      "asWKT":[
        {
          "type":"WKTLiteral",
          "@value":"Point ( +011.481700 +063.793320 )"
        }
      ]
    }
  ]
}

We just have to adjust the context a bit adding the type to asWKT there, see http://tinyurl.com/y7872mxl

@acka47 acka47 self-assigned this May 9, 2018
acka47 added a commit that referenced this issue May 9, 2018
See #101
@acka47 acka47 added the working label May 9, 2018
@acka47 acka47 added review and removed working labels May 9, 2018
fsteeg added a commit that referenced this issue May 9, 2018
@fsteeg
Copy link
Member

@fsteeg fsteeg commented May 9, 2018

Updated the JSON processing code for the new structure. Will deploy with next full conversion.

@fsteeg fsteeg added working and removed review labels May 9, 2018
@fsteeg fsteeg assigned fsteeg and unassigned acka47 May 9, 2018
@acka47
Copy link
Contributor Author

@acka47 acka47 commented May 9, 2018

For now, we will only remove the extra object with the @value. Before we move this to production, we will have to think about aligning with EntityFacts, where the next release will contain geo coordinates and they use another approach, see https://wiki.dnb.de/pages/viewpage.action?pageId=134055670.

I just talked to @jentschk and there might be some future adjustments to the EntityFacts go information. She will open a discussion about this on a mailing list.

fsteeg added a commit that referenced this issue May 9, 2018
@fsteeg fsteeg self-assigned this May 9, 2018
@fsteeg
Copy link
Member

@fsteeg fsteeg commented May 14, 2018

@fsteeg fsteeg assigned acka47 and unassigned fsteeg May 14, 2018
@fsteeg fsteeg added review and removed working labels May 14, 2018
@acka47
Copy link
Contributor Author

@acka47 acka47 commented May 14, 2018

+1 for the adjustments. @jentschk started a mailing list thread at http://lists.dnb.de/pipermail/lds/2018-May/000118.html regarding the JSON-LD representation of geodata (including polygons). We should provide some feedback soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants