Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set redirect and delete old entry when entries were merged #117

Closed
acka47 opened this Issue Jun 8, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@acka47
Copy link
Contributor

acka47 commented Jun 8, 2018

Reqeuested via email.

On 08.06.2018 12:03, P.R. wrote:

Ein Problem, das ein paar Mal aufgetaucht ist, ist die Zusammenlegung doppelt angelegter individualisierter Personensätze in der GND: zum Beispiel 1090750048 und 111508401. Hier wäre es für mich ideal, wenn bei Abfrage des aufgelösten Datensatzes (hier 1090750048) eine Weiterleitung zum fortgeführten Datensatz (als 111508401) erkennbar wäre

Currently, we still have both entries in lobid-gnd so it might be the case that deletions are not taken into account in the update workflow right now:

The merged record (111508401) has information in it about the ID of the deleted record, both in oldAuthorityNumbern in deprecatedUri:

{
  "@context":"http://lobid.org/gnd/context.jsonld",
  "id":"http://d-nb.info/gnd/111508401",
  "oldAuthorityNumber":[
    "(DE-588a)111508401",
    "(DE-588)1090750048"
  ],
  "deprecatedUri":[
    "http://d-nb.info/gnd/1090750048"
  ]
}

There are two values in oldAuthorityNumber and only one in deprecatedUri. I guess the second only reflects the changes after the start of the Linked Data GND service while the other also gives back old IDs from before that. (This would also explain that there are ~400k entries with deprecatedUri but >9 Million entries with oldAuthorityNumber.)

For implementing this feature I think it is sufficient to work with the deprecatedUri field and I suggest the following:

  • When someone directly looks up an entry there is a lookup in deprecatedUri whether there is a match of the GND ID.
  • If yes, the client is redirected to the resource containing the deprecatedUri entry.

Nonetheless, we have to get rid of the deleted entry on a regular basis and not only when indexing a new base dump. Otherwise, search results will contain deprecated entries.

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Jun 8, 2018

I just took a look at the many values in oldAuthorityNumber. They obviously stem from the time before the GND when different authority files for Körperschaften, Personen, Schlagwörter etc. existed. If I only search for entries with "(DE-558)" in this field (and not DE-558a, DE-558b, DE-558c for the old deprecated ones) I get exactly the same amount of records as with querying for deprecatedUri:

http://lobid.org/gnd/search?q=oldAuthorityNumber%3A%22%28DE-588%29%22
vs.
http://lobid.org/gnd/search?q=_exists_%3AdeprecatedUri

@fsteeg fsteeg added ready working and removed ready labels Jun 13, 2018

fsteeg added a commit that referenced this issue Jun 13, 2018

fsteeg added a commit that referenced this issue Jun 13, 2018

@acka47 acka47 added review and removed working labels Jun 13, 2018

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Jun 13, 2018

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Jun 13, 2018

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Jun 13, 2018

+1 for the redirect. Shall I open another issue for removing deleted entries (because the entries are still delivered via the API when querying, e.g. http://lobid.org/gnd/search?q=Erdmann%2C+Elisabeth+von),

@acka47 acka47 removed their assignment Jun 13, 2018

@fsteeg fsteeg changed the title Set redirect when entries were merged Set redirect and delete old entry when entries were merged Jun 14, 2018

@fsteeg fsteeg self-assigned this Jun 14, 2018

@fsteeg fsteeg added working and removed review labels Jun 14, 2018

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Jun 14, 2018

Shall I open another issue for removing deleted entries

I'll continue with the deletion here.

fsteeg added a commit that referenced this issue Jun 14, 2018

fsteeg added a commit that referenced this issue Jun 14, 2018

fsteeg added a commit that referenced this issue Jun 15, 2018

fsteeg added a commit that referenced this issue Jun 15, 2018

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Jun 15, 2018

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Jun 15, 2018

@fsteeg fsteeg added review and removed working labels Jun 15, 2018

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Jun 18, 2018

Nice. +1

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Jun 18, 2018

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Jun 18, 2018

I wrote and sent the email. Closing.

@acka47 acka47 closed this Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.