Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to catch not-compacted properties #171

Closed
acka47 opened this issue Dec 7, 2018 · 7 comments
Closed

Add tests to catch not-compacted properties #171

acka47 opened this issue Dec 7, 2018 · 7 comments
Assignees

Comments

@acka47
Copy link
Contributor

@acka47 acka47 commented Dec 7, 2018

As said in #163 (comment) we need some mechanism to check whether all properties are compacted in the lobid-gnd JSON-LD or whether some keys exist that are a URI.

This might best be implemented using the GET mapping mechanism.

@acka47
Copy link
Contributor Author

@acka47 acka47 commented Dec 10, 2018

See #89 (comment) as current case where we have problems with not automatically detecting not-compacted keys. (Although I knew about this change and should have prepared the context, a test would of course be fine to catch it when we miss something.)

@acka47
Copy link
Contributor Author

@acka47 acka47 commented Dec 10, 2018

The tests should at best run before a new index is deployed to production.

@acka47 acka47 assigned dr0i and unassigned fsteeg Dec 10, 2018
@acka47
Copy link
Contributor Author

@acka47 acka47 commented Dec 10, 2018

As discussed today, this is a good issue for @dr0i to help out with lobid-gnd.

@dr0i dr0i added the ready label Dec 10, 2018
@dr0i dr0i added working and removed ready labels Dec 28, 2018
@dr0i
Copy link
Contributor

@dr0i dr0i commented Dec 28, 2018

quick note: curl weywot5.hbz-nrw.de:9200/gnd/_mapping | jq -r 'paths | map(.|tostring)|join(".")' |grep http.*properties. |grep -vE '.properties(.id|.label)(.*)$' |grep -vE '.properties$'
where have to get the proper index name of course.

dr0i added a commit that referenced this issue Jan 8, 2019
@dr0i
Copy link
Contributor

@dr0i dr0i commented Jan 8, 2019

As mailing was not working on quaoar1: uninstalled postfix and installed sendmail.

@dr0i
Copy link
Contributor

@dr0i dr0i commented Jan 8, 2019

TODO: get/set index-name which shall be checked.

dr0i added a commit that referenced this issue Jan 10, 2019
dr0i added a commit that referenced this issue Jan 10, 2019
dr0i added a commit that referenced this issue Jan 11, 2019
dr0i added a commit that referenced this issue Jan 11, 2019
dr0i added a commit that referenced this issue Jan 11, 2019
dr0i added a commit that referenced this issue Jan 11, 2019
@dr0i
Copy link
Contributor

@dr0i dr0i commented Jan 11, 2019

Done setting index name.
Deployed. Closing

@dr0i dr0i closed this Jan 11, 2019
@dr0i dr0i removed the working label Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants