Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML is broken when geo coordinates are a polygon #192

Closed
acka47 opened this Issue Mar 29, 2019 · 2 comments

Comments

2 participants
@acka47
Copy link
Contributor

commented Mar 29, 2019

See e.g. http://lobid.org/gnd/4099668-2.html or any entry from this list of 79 places: http://lobid.org/gnd/search?q=hasGeometry.asWKT%3APolygon

From the JSON:

{
   "hasGeometry":[
      {
         "type":"http://www.opengis.net/ont/sf#Polygon",
         "asWKT":[
            "Polygon (( +009.711666 +052.364444, +009.711666 +052.364444, +009.711388 +052.364444, +009.711388 +052.364444, +009.711666 +052.364444 ))"
         ]
      }
   ]
}

I suggest to not show the map whenever hasGeometry.type is http://www.opengis.net/ont/sf#Polygon (which we also should add to the context to only just read Polygon.

@acka47 acka47 added this to Backlog in lobid board Apr 8, 2019

@fsteeg fsteeg added the bug label Apr 12, 2019

@fsteeg fsteeg moved this from Backlog to Ready in lobid board Apr 12, 2019

@fsteeg fsteeg moved this from Ready to Working in lobid board Apr 12, 2019

fsteeg added a commit that referenced this issue Apr 12, 2019

@fsteeg

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Deployed to test (taking on of the polygon points, not ideal for larger units, but better than the current error):

http://test.lobid.org/gnd/search?q=hasGeometry.asWKT:Polygon

acka47 added a commit that referenced this issue Apr 12, 2019

@acka47

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

+1 (I also added http://www.opengis.net/ont/sf#Polygon to the context as said above.)

@acka47 acka47 moved this from Working to Review in lobid board Apr 12, 2019

@fsteeg fsteeg closed this in #197 Apr 15, 2019

lobid board automation moved this from Review to Done Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.