Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to ID fields #24

Closed
acka47 opened this Issue Sep 13, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@acka47
Copy link
Contributor

acka47 commented Sep 13, 2017

For example http://test.lobid.org/authorities/118506560.

Currently looks like:

{
"professionOrOccupation": [
  "http://d-nb.info/gnd/4131406-2",
  "http://d-nb.info/gnd/4012434-4"
  ]
}

With added labels:

{
   "professionOrOccupation":[
      {
         "id":"http://d-nb.info/gnd/4131406-2",
         "preferredName":"Pianist"
      },
      {
         "id":"http://d-nb.info/gnd/4012434-4",
         "preferredName":"Dirigent"
      }
   ]
}

However, there are several other cases (e.g. placeOfDeath, relatedWork, familialRelationship) where we only have internal GND links without labels in the data. Thus, a general approach would probably make sense to automatically add a label for all URIs from the http://d-nb.info/gnd/ namespace. (If we implement a general approach, it should be possible to exclude some properties from this label enrichment, e.g. we might get problems with trying to fetch the label for deprecatedUri and also labels for sameAs links within GND aren't necessary I think.) What do you think, @fsteeg?

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Sep 13, 2017

From the logic/implementation view this should work. We already get labels for GND URIs in the UI. We could use the previous index data when running a transformation. It would significantly increase processing runtime however, since we'd have to analyze every record for values to add, and issue multiple index requests for each record.

@fsteeg fsteeg self-assigned this Sep 22, 2017

@fsteeg fsteeg added the ready label Sep 22, 2017

@fsteeg fsteeg removed the ready label Mar 8, 2018

@fsteeg fsteeg referenced this issue Mar 8, 2018

Closed

Design detail view #27

@fsteeg fsteeg changed the title Add labels to professionOrOccupation Add labels to ID fields Mar 16, 2018

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Mar 16, 2018

Full list of ID fields to add labels for (taken from #26):

  • professionOrOccupation
  • placeOfBusiness
  • placeOfConferenceOrEvent
  • firstAuthor (firstComposer etc.)
  • geographicAreaCode (depends on #17)
  • gndSubjectCategory (depends on #17)

@fsteeg fsteeg added the ready label Apr 12, 2018

@fsteeg fsteeg added working and removed ready labels Apr 24, 2018

fsteeg added a commit that referenced this issue Apr 25, 2018

@fsteeg fsteeg added ready and removed working labels Apr 26, 2018

fsteeg added a commit that referenced this issue Apr 27, 2018

@fsteeg fsteeg added working and removed ready labels Apr 30, 2018

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Apr 30, 2018

Data deployed to test: http://test.lobid.org/gnd/118506560.json

@acka47 You can already take a look at the data if you want to. I will continue in this issue with:

  1. Fixing the indexing problems due to the object structure that I mentioned earlier in our call
  2. UI updates to use the new labels from the data, replacing API calls for labels in the UI

@fsteeg fsteeg assigned acka47 and unassigned dr0i Apr 30, 2018

fsteeg added a commit that referenced this issue Apr 30, 2018

fsteeg added a commit that referenced this issue May 2, 2018

fsteeg added a commit that referenced this issue May 2, 2018

fsteeg added a commit that referenced this issue May 2, 2018

@fsteeg fsteeg removed the working label May 2, 2018

@fsteeg fsteeg added the review label May 2, 2018

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented May 2, 2018

@fsteeg fsteeg removed their assignment May 2, 2018

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented May 3, 2018

+1

@acka47 acka47 removed their assignment May 3, 2018

@fsteeg fsteeg added deploy and removed review labels May 3, 2018

@fsteeg fsteeg closed this in #95 May 3, 2018

fsteeg added a commit that referenced this issue May 3, 2018

@fsteeg fsteeg removed the deploy label May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.