Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reconciliation" of GND identifiers #247

Open
wetneb opened this issue Dec 2, 2019 · 7 comments
Open

"Reconciliation" of GND identifiers #247

wetneb opened this issue Dec 2, 2019 · 7 comments
Projects

Comments

@wetneb
Copy link

@wetneb wetneb commented Dec 2, 2019

Just making sure you had seen this, from OpenRefine's mailing list:
https://groups.google.com/d/msgid/openrefine/0b677083-2be3-437c-8f8c-f61b7234330b%40googlegroups.com

A reconciliation query containing a GND identifier as text (such as 132390299) does not give any results, whereas a suggest query for the same text returns the expected result.

@acka47

This comment has been minimized.

Copy link
Contributor

@acka47 acka47 commented Dec 2, 2019

Thanks for the hint. No one from the lobid team was a subscriber until now. I will subscribe to the list today.

Regarding the conrete problem, we should probably add gndIdentifier to the list of fields a reconciliation query is matched against:

QueryStringQueryBuilder mainQuery = QueryBuilders.queryStringQuery(queryString)//
.field("preferredName", 4f)//
.field("variantName", 2f)//
.field("temporaryName")//
.field("abbreviatedNameForTheConferenceOrEvent")//
.field("abbreviatedNameForThePlaceOrGeographicName")//
.field("abbreviatedNameForTheWork")//
.field("abbreviatedNameForTheCorporateBody");//

@acka47 acka47 added this to Backlog in lobid board via automation Dec 2, 2019
@acka47 acka47 moved this from Backlog to Ready in lobid board Dec 2, 2019
@acka47

This comment has been minimized.

Copy link
Contributor

@acka47 acka47 commented Dec 2, 2019

We should probably also add sameAs.collection.id sameAs.id where the corresponding identifiers from other sources are located. People might even be more interested in using external identifiers for reconciliation than GND IDs.

fsteeg added a commit that referenced this issue Dec 2, 2019
@fsteeg

This comment has been minimized.

Copy link
Member

@fsteeg fsteeg commented Dec 3, 2019

@fsteeg fsteeg assigned fsteeg and unassigned acka47 Dec 3, 2019
@fsteeg fsteeg moved this from Review to Working in lobid board Dec 3, 2019
fsteeg added a commit that referenced this issue Dec 3, 2019
fsteeg added a commit that referenced this issue Dec 3, 2019
@fsteeg fsteeg assigned acka47 and unassigned fsteeg Dec 3, 2019
@fsteeg fsteeg moved this from Working to Review in lobid board Dec 3, 2019
@acka47

This comment has been minimized.

Copy link
Contributor

@acka47 acka47 commented Dec 4, 2019

Works mostly fine but it doesn't work with ORCIDs, e.g. http://orcid.org/0000-0003-0232-7085.

@acka47 acka47 assigned fsteeg and unassigned acka47 Dec 4, 2019
@acka47

This comment has been minimized.

Copy link
Contributor

@acka47 acka47 commented Dec 4, 2019

My bad, I took non-http ORCID URIs from the production system. On staging, there are https-URIs. So everything works fine. +1

fsteeg added a commit that referenced this issue Dec 5, 2019
@fsteeg fsteeg moved this from Review to Deploy in lobid board Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.