Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve (sub-)type filtering #42

Closed
acka47 opened this Issue Feb 23, 2018 · 14 comments

Comments

Projects
None yet
4 participants
@acka47
Copy link
Contributor

acka47 commented Feb 23, 2018

Currently, we only allow filtering by first-level types Person, CorporateBody, ConferenceOrEvent, Work, PlaceOrGeographicName, SubjectHeading, Family.

One adjustment should be that the filter section adjusts when clicking on a type: Either the not-clicked first-level types shoud disappear (and the sub-types should be shown, see below) or the not-clicked types should be greyed out.

We should also enable filtering by the subtypes in these two ways:

  1. Add a "+" sign to first-level types with sub-typing so that people can klick on it and the sub-types are shown. (E.g. for "Place or Geographic Name" "Building or Memorial", "Administrative Unit", "Fictive Place" etc.)
  2. Filtering by a first-level type should yield filtered search results with sub-facets opening up

@fsteeg fsteeg added the ready label Mar 16, 2018

fsteeg added a commit that referenced this issue Mar 20, 2018

Change type facet to drill down behavior
- Show sub types if any type filter is active
- Apply active type filter to the aggregation

See #42

@fsteeg fsteeg added working and removed ready labels Mar 20, 2018

fsteeg added a commit that referenced this issue Mar 20, 2018

fsteeg added a commit that referenced this issue Mar 20, 2018

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Mar 20, 2018

Deployed drill down in type facet to test: http://test.lobid.org/gnd/search

@fsteeg fsteeg added review and removed working labels Mar 20, 2018

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Mar 20, 2018

@fsteeg fsteeg assigned fsteeg and unassigned fsteeg Mar 20, 2018

fsteeg added a commit that referenced this issue Mar 20, 2018

Improve visual structure of type facet
- Sort facet links first by being selected, second by doc count
- Use arrows for tree-like look of unselected sub types in facet

See #42
@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Mar 20, 2018

Updated with improved visual structure as discussed offline: http://test.lobid.org/gnd/search

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Mar 20, 2018

Looks better but there isn't any order in the subtype list. Ordering by number of occurences would make most sense I guess.

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Mar 20, 2018

We also have to think about another representation of the filters chosen when you have clicked on a "sub type". As there are different things adding up, maybe we should take a step back and think about a good usage concept of filtering by type and subtypes...

fsteeg added a commit that referenced this issue Mar 21, 2018

Fix order of facet entries
- Don't sort buckets, leave order by doc count
- First show selected top-level, then other selected, then rest

See #42
@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Mar 21, 2018

Updated with improved order of facet entries: http://test.lobid.org/gnd/search

fsteeg added a commit that referenced this issue Mar 21, 2018

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Mar 22, 2018

We decided to not only show top levels in the facets from the beginning but also sub-classes indented below their super class.

@acka47 acka47 added working ready and removed review working labels Mar 22, 2018

@acka47 acka47 assigned fsteeg and unassigned acka47 Mar 22, 2018

@fsteeg fsteeg removed the ready label Mar 22, 2018

@fsteeg fsteeg added working ready and removed review working ready labels Apr 3, 2018

fsteeg added a commit that referenced this issue Apr 4, 2018

fsteeg added a commit that referenced this issue Apr 4, 2018

fsteeg added a commit that referenced this issue Apr 4, 2018

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Apr 4, 2018

@fsteeg fsteeg added review and removed working labels Apr 4, 2018

@fsteeg fsteeg assigned acka47 and ChristophEwertowski and unassigned fsteeg Apr 4, 2018

fsteeg added a commit that referenced this issue Apr 4, 2018

fsteeg added a commit that referenced this issue Apr 4, 2018

fsteeg added a commit that referenced this issue Apr 4, 2018

fsteeg added a commit that referenced this issue Apr 4, 2018

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Apr 5, 2018

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Apr 5, 2018

+1

@acka47 acka47 removed their assignment Apr 5, 2018

@ChristophEwertowski

This comment has been minimized.

Copy link
Contributor

ChristophEwertowski commented Apr 5, 2018

+1

@fsteeg fsteeg removed their assignment Apr 5, 2018

@dr0i dr0i added deploy and removed review labels Apr 5, 2018

@fsteeg fsteeg closed this in #54 Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.