Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data extension response metadata #242

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@fsteeg
Copy link
Member

commented Oct 8, 2019

Include property types only where values are GND entities

Will resolve #241

Include property types only where values are GND entities

See #241
@fsteeg fsteeg added this to Working in lobid board via automation Oct 8, 2019
@fsteeg fsteeg moved this from Working to Review in lobid board Oct 8, 2019
@acka47 acka47 requested a review from dr0i Oct 9, 2019
@@ -225,7 +231,8 @@ private static void loadTypes(String f) throws SAXException, IOException {
$(property).find(selector("range")).forEach(domain -> {
String type = domain.getAttribute("rdf:resource");
String shortType;
if (type != null && type.contains("#") && !(shortType = type.split("#")[1]).equals("Literal")) {
if (type != null && type.startsWith("http://d-nb.info/standards/elementset/gnd#")
&& !(shortType = type.split("#")[1]).equals("Literal")) {

This comment has been minimized.

Copy link
@dr0i

dr0i Oct 10, 2019

Contributor

It may be nicer to reuse the constant in https://github.com/hbz/lobid-gnd/blob/master/app/models/AuthorityResource.java#L33 as prefix for "elementset/gnd#" or even put that whole String as constant into that class.

// curl -g
// 'localhost:9000/gnd/reconcile?extend=
// {"ids":[],"properties":[{"id":"geographicAreaCode"},{"id":"professionOrOccupation"}]}'
// See https://github.com/hbz/lobid-gnd/issues/241

This comment has been minimized.

Copy link
@dr0i

dr0i Oct 10, 2019

Contributor

this seems to be redundant because it is said line 187 in java, but I like it

lobid board automation moved this from Review to Deploy Oct 10, 2019
@dr0i
dr0i approved these changes Oct 10, 2019
@dr0i

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

+1

@fsteeg fsteeg merged commit d4473a5 into master Oct 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
lobid board automation moved this from Deploy to Done Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.