Add type schema:Library to all DBS resources #29

Closed
acka47 opened this Issue Jan 26, 2015 · 7 comments

Comments

Projects
None yet
4 participants
@acka47
Contributor

acka47 commented Jan 26, 2015

We already added type information to resource from the ISIL registry, see lobid/lodmill#509. We also have to add type information to the resources from DBS. As all of them are libraries we can globally type them as schema:Library.

@acka47

This comment has been minimized.

Show comment
Hide comment
@acka47

acka47 Jan 26, 2015

Contributor

Assigning @SBRitter. Simon, let me know if you don't have the time and I will reassign.

Contributor

acka47 commented Jan 26, 2015

Assigning @SBRitter. Simon, let me know if you don't have the time and I will reassign.

@SBRitter

This comment has been minimized.

Show comment
Hide comment
@SBRitter

SBRitter Jan 27, 2015

Contributor

I see the point. I added a rule for DBS-only entries and opened up a pull request. However, I am not really able to test the new transformation as I have only access to the sample data.

Contributor

SBRitter commented Jan 27, 2015

I see the point. I added a rule for DBS-only entries and opened up a pull request. However, I am not really able to test the new transformation as I have only access to the sample data.

@acka47 acka47 added the review label Mar 31, 2015

@acka47 acka47 assigned dr0i and unassigned SBRitter Mar 31, 2015

@dr0i dr0i assigned SBRitter and unassigned dr0i Apr 1, 2015

@dr0i

This comment has been minimized.

Show comment
Hide comment
@dr0i

dr0i Apr 1, 2015

Contributor

You now have access to the data? If not : what data execatly to you need?

Contributor

dr0i commented Apr 1, 2015

You now have access to the data? If not : what data execatly to you need?

@dr0i

This comment has been minimized.

Show comment
Hide comment
@dr0i

dr0i Apr 1, 2015

Contributor

Uhm, sorry @SBRitter . I think it was meant that I the task, away from you.

Contributor

dr0i commented Apr 1, 2015

Uhm, sorry @SBRitter . I think it was meant that I the task, away from you.

@dr0i dr0i assigned dr0i and unassigned SBRitter Apr 1, 2015

@dr0i dr0i assigned philboeselager and unassigned dr0i May 20, 2015

@philboeselager

This comment has been minimized.

Show comment
Hide comment
@philboeselager

philboeselager May 21, 2015

Contributor

Should we add some schema:PostalAddress to DBS data as well? (Unclassified yet.)

Contributor

philboeselager commented May 21, 2015

Should we add some schema:PostalAddress to DBS data as well? (Unclassified yet.)

@acka47 acka47 assigned philboeselager and unassigned acka47 May 21, 2015

@acka47 acka47 added the in progress label May 21, 2015

dr0i added a commit that referenced this issue May 27, 2015

Merge pull request #43 from hbz/issue/#29
Add schema.org information to processed DBS data

@dr0i dr0i assigned philboeselager and unassigned dr0i May 29, 2015

@acka47

This comment has been minimized.

Show comment
Hide comment
@acka47

acka47 Jun 1, 2015

Contributor

Should we add some schema:PostalAddress to DBS data as well? (Unclassified yet.)

I already told you face to face: Please add it in the location object, e.g.:

{
  "id": "http://beta.lobid.org/organisations/DBS-AA609",
  "location": [ {
        "address": {
        "type": "http://schema.org/PostalAddress",
        "streetAddress": "Am Honigbraum 13",
        "addressLocality": "Eppstein-Niederjasbach"
        }
     }
  ]
}
Contributor

acka47 commented Jun 1, 2015

Should we add some schema:PostalAddress to DBS data as well? (Unclassified yet.)

I already told you face to face: Please add it in the location object, e.g.:

{
  "id": "http://beta.lobid.org/organisations/DBS-AA609",
  "location": [ {
        "address": {
        "type": "http://schema.org/PostalAddress",
        "streetAddress": "Am Honigbraum 13",
        "addressLocality": "Eppstein-Niederjasbach"
        }
     }
  ]
}
@acka47

This comment has been minimized.

Show comment
Hide comment
@acka47

acka47 Jun 10, 2015

Contributor

+1. Looks very good and is appreciated. Closing.

Contributor

acka47 commented Jun 10, 2015

+1. Looks very good and is appreciated. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment