Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add responsibilityStatement (field 245??.c) #1194

Closed
dr0i opened this issue Apr 13, 2021 · 5 comments · Fixed by #1197
Closed

Add responsibilityStatement (field 245??.c) #1194

dr0i opened this issue Apr 13, 2021 · 5 comments · Fixed by #1197
Assignees
@dr0i
Labels
ALMA
Projects
lobid board
Milestone
almaMigration

Comments

@dr0i
Copy link
Member

dr0i commented Apr 13, 2021

Like in http://lobid.org/resources/HT000068434.json we need responsibilityStatement in http://alma.lobid.org/resources/990000597810206441.json.
@dr0i dr0i added this to Backlog in lobid board via automation Apr 13, 2021
@dr0i dr0i added this to the almaMigration milestone Apr 13, 2021
@dr0i
Copy link
Member Author

dr0i commented Apr 13, 2021

There is already a test resource reflecting this field: (DE-605)HT020202475.xml.

@dr0i dr0i moved this from Backlog to Ready in lobid board Apr 13, 2021
@TobiasNx TobiasNx changed the title Add responsibilityStatement (field 24512.c) Add responsibilityStatement (field 245??.c) Apr 14, 2021
@TobiasNx
Copy link
Contributor

Subfield .c is prrovided with every 245 field, which appearse once in a record.

@TobiasNx
Copy link
Contributor

TobiasNx commented Apr 15, 2021 •
edited

@acka47: responsibilityStatement is an array. The source of it is a non repeatable field 245??c (MAB 359# $$a). Should this be changed to a string value, or is this a too strong api break?

@TobiasNx TobiasNx assigned acka47 and unassigned TobiasNx Apr 15, 2021
@TobiasNx TobiasNx linked a pull request Apr 15, 2021 that will close this issue
Add responsibility statement #1197
Merged
@TobiasNx TobiasNx mentioned this issue Apr 15, 2021
Merged
@acka47
Copy link
Contributor

acka47 commented Apr 15, 2021

responsibilityStatement is an array. The source of it is a non repeatable field 245??c (MAB 359# $$a). Should this be changed to a string value, or is this a too strong api break?

This would be an API break, yes. As discussed in the meeting today, we will leave it like this.

@acka47 acka47 assigned TobiasNx and unassigned acka47 Apr 15, 2021
@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Apr 15, 2021
@TobiasNx TobiasNx moved this from Ready to Review in lobid board Apr 15, 2021
dr0i added a commit that referenced this issue Apr 15, 2021
@dr0i
Undo formatting
f6ba4be 
See #1194.
@dr0i dr0i moved this from Review to Deploy in lobid board Apr 15, 2021
@dr0i
Copy link
Member Author

dr0i commented Apr 16, 2021

Deployed, see e.g. http://alma.lobid.org/resources/990001412590206441.json and http://alma.lobid.org/resources/990000597810206441.json.

lobid board automation moved this from Deploy to Done Apr 16, 2021
@TobiasNx TobiasNx mentioned this issue Apr 23, 2021
Closed
@TobiasNx TobiasNx added the ALMA label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr0i dr0i

Labels
ALMA
Projects
lobid board
Done
Milestone
almaMigration
Development

Successfully merging a pull request may close this issue.

Add responsibility statement hbz/lobid-resources
3 participants
@acka47 @dr0i @TobiasNx