Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use relators as property but indicate relator via "role" property #38

Closed
acka47 opened this issue Feb 26, 2016 · 7 comments
Closed

Don't use relators as property but indicate relator via "role" property #38

acka47 opened this issue Feb 26, 2016 · 7 comments
Assignees
Labels

Comments

@acka47
Copy link
Contributor

@acka47 acka47 commented Feb 26, 2016

As discussed in #10 , we will indicate the roles of a contributor in the contributor object with the "role" property and won't use relators as properties.

Example:

{
  "@context": {
    "id": "@id",
    "type": "@type",
    "role": "http://bibframe.org/vocab/relator",
    "contributor": {
      "@type": "@id",
      "@id": "http://purl.org/dc/terms/contributor",
      "@container": "@set"
    },
    "label": "http://www.w3.org/2000/01/rdf-schema#label",
    "altLabel": "http://www.w3.org/2004/02/skos/core#altLabel",
    "subject": {
      "@type": "@id",
      "@id": "http://purl.org/dc/terms/subject",
      "@container": "@list"
    }
  },
  "@id" : "http://lobid.org/resources/HT018843259#!",
  "contributor": [ {
    "id": "http://d-nb.info/gnd/118548018",
    "type": "DifferentiatedPerson",
    "role": {
      "id": "http://id.loc.gov/vocabulary/relators/cre",
      "label": "Autor/in"
    },
    "label": "Becker, Thomas Paul",
    "altLabel": [ "Becker, Thomas P." ]
  } ],
  "subject": [ {
     "id" : "http://d-nb.info/gnd/4031485-6",
     "type": "PlaceOrGeographicName",
     "label": "Erzstift Köln",
     "altLabel": [ "Kölner Krieg", "Truchsessischer Krieg" ]
  } ]
}

We won't be able to only use a string as value for "role" as proposed in #10 but will – as you can see in the example – also use the side car approach here – giving us presentation labels for the different roles in the data.

@acka47
Copy link
Contributor Author

@acka47 acka47 commented Nov 8, 2016

@jschnasse just pointed out that the approach we chose above is not correct as it associates the role with the person. As the role is a relation between the person and the resource this has to somehow be made clear. Taking a look at Bibframe 2.0, it seems to be a reasonable approach. An example from http://www.loc.gov/bibframe/docs/pdf/bf2-roles-apr2016.pdf:

<http://bibframe.example.org/resource> bf:contribution [
    a bf:Contribution ;
    bf:role “illustrator” ;
    bf:agent <http://id.loc.gov/rwo/agents/n94064763> ] .

For the example above, the result would look like this:

{
  "@context": {
    "id": "@id",
    "type": "@type",
    "agent": "http://bibframe.org/vocab/agent",
    "role": "http://bibframe.org/vocab/relator",
    "conbtribution": "http://bibframe.org/vocab/contribution",
    "Contribution": "http://bibframe.org/vocab/Contribution",
    "label": "http://www.w3.org/2000/01/rdf-schema#label",
    "altLabel": "http://www.w3.org/2004/02/skos/core#altLabel",
    "subject": {
      "@type": "@id",
      "@id": "http://purl.org/dc/terms/subject",
      "@container": "@list"
    }
  },
  "id" : "http://lobid.org/resources/HT018843259#!",
  "contribution": [ {
    "type": "Contribution",
    "role": {
    "id": "http://id.loc.gov/vocabulary/relators/cre",
    "label": "Autor/in"
    },
    "agent": {
      "id": "http://d-nb.info/gnd/118548018",
      "type": "DifferentiatedPerson",
      "label": "Becker, Thomas Paul",
      "altLabel": [ "Becker, Thomas P." ]
      }
  } ],
  "subject": [ {
     "id" : "http://d-nb.info/gnd/4031485-6",
     "type": "PlaceOrGeographicName",
     "label": "Erzstift Köln",
     "altLabel": [ "Kölner Krieg", "Truchsessischer Krieg" ]
  } ]
}
@acka47
Copy link
Contributor Author

@acka47 acka47 commented Nov 8, 2016

Here is an example with multiple contributions:

{
   "@context":{
      "id":"@id",
      "type":"@type",
      "agent":"http://bibframe.org/vocab/agent",
      "role":"http://bibframe.org/vocab/relator",
      "contribution":"http://bibframe.org/vocab/contribution",
      "Contribution":"http://bibframe.org/vocab/Contribution",
      "label":"http://www.w3.org/2000/01/rdf-schema#label",
      "altLabel":"http://www.w3.org/2004/02/skos/core#altLabel",
      "subject":{
         "@type":"@id",
         "@id":"http://purl.org/dc/terms/subject",
         "@container":"@list"
      }
   },
   "id":"http://lobid.org/resources/HT019093814#!",
   "contribution":[
      {
         "type":"Contribution",
         "role":{
            "id":"http://id.loc.gov/vocabulary/relators/pht",
            "label":"Fotografie"
         },
         "agent":{
            "id":"http://d-nb.info/gnd/1067217789",
            "label":"Ganslmeier, Jakob",
            "type":[
               "Person"
            ]
         }
      },
      {
         "type":"Contribution",
         "role":{
            "id":"http://id.loc.gov/vocabulary/relators/pht",
            "label":"Fotografie"
         },
         "agent":{
            "id":"http://d-nb.info/gnd/1108328849",
            "label":"Boeszoermeny, Louisa",
            "type":[
               "Person"
            ]
         }
      },
      {
         "type":"Contribution",
         "role":{
            "id":"http://id.loc.gov/vocabulary/relators/ctb",
            "label":"Mitwirkung"
         },
         "agent":{
            "id":"http://d-nb.info/gnd/5555595-0",
            "label":"Kultur Ruhr GmbH",
            "type":[
               "CorporateBody"
            ]
         }
      },
      {
         "type":"Contribution",
         "role":{
            "id":"http://id.loc.gov/vocabulary/relators/ctb",
            "label":"Mitwirkung"
         },
         "agent":{
            "id":"http://d-nb.info/gnd/7741856-6",
            "label":"Kultur Ruhr GmbH",
            "type":[
               "CorporateBody"
            ]
         }
      }
   ]
}
@dr0i dr0i added working and removed ready labels Nov 18, 2016
@dr0i dr0i added ready and removed working labels Nov 22, 2016
dr0i added a commit that referenced this issue Nov 25, 2016
Instead of using flat properties, such as dct:creator or marcrel:sng, no every
entity is a dct:contributor with roles (depicting that entity as creator,
singer etc.).

See #38.
dr0i added a commit that referenced this issue Nov 25, 2016
Instead of using flat properties, such as dct:creator or marcrel:sng, no every
entity is a dct:contributor with roles (depicting that entity as creator,
singer etc.).

See #38.
dr0i added a commit to hbz/lobid-rdf-to-json that referenced this issue Nov 25, 2016
dr0i added a commit that referenced this issue Nov 25, 2016
Instead of using flat properties, such as dct:creator or marcrel:sng, no every
entity is a dct:contributor with roles (depicting that entity as creator,
singer etc.).

See #38.
@dr0i dr0i added ready and removed working labels Dec 1, 2016
dr0i added a commit that referenced this issue Dec 2, 2016
See #38.
dr0i added a commit that referenced this issue Dec 2, 2016
Brauchst einen bnode fuer die agents wenn ohne ID:
MapperParsingException[object mapping for [contribution.agent] tried to parse field [agent] as object, but found a concrete value]

sihe TT050409948

See #38.
@acka47
Copy link
Contributor Author

@acka47 acka47 commented Dec 7, 2016

When we are finished with this we can clean up our JSON-LD context by removing all the MARC relator entries. We will need them in labels.json, though.

{
   "cinematographer":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/cng",
      "@container":"@set"
   },
   "engraver":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/egr",
      "@container":"@set"
   },
   "collaborator":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/clb",
      "@container":"@set"
   },
   "bibliographicAntecedent":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/ant",
      "@container":"@set"
   },
   "introductionBy":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/aui",
      "@container":"@set"
   },
   "cartographer":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/ctg",
      "@container":"@set"
   },
   "director":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/drt",
      "@container":"@set"
   },
   "singer":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/sng",
      "@container":"@set"
   },
   "musician":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/mus",
      "@container":"@set"
   },
   "performer":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/prf",
      "@container":"@set"
   },
   "composer":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/cmp",
      "@container":"@set"
   },
   "conductor":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/cnd",
      "@container":"@set"
   },
   "actor":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/act",
      "@container":"@set"
   },
   "afterwordBy":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/aft",
      "@container":"@set"
   },
   "redaktor":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/red",
      "@container":"@set"
   },
   "producer":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/pro",
      "@container":"@set"
   },
   "dedicatee":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/dte",
      "@container":"@set"
   },
   "honoree":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/hnr",
      "@container":"@set"
   },
   "collector":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/col",
      "@container":"@set"
   },
   "photographer":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/pht",
      "@container":"@set"
   },
   "screenwriter":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/aus",
      "@container":"@set"
   },
   "interviewer":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/ivr",
      "@container":"@set"
   },
   "contributor_":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/ctb",
      "@container":"@set"
   },
   "interviewee":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/ive",
      "@container":"@set"
   },
   "illustrator":{
      "@type":"@id",
      "@id":"http://id.loc.gov/vocabulary/relators/ill",
      "@container":"@set"
   }
}
dr0i added a commit that referenced this issue Dec 7, 2016
fast geschafft - zwei labels für _:BIrlenbusch

Brauchst einen bnode fuer die agents wenn ohne ID:
MapperParsingException[object mapping for [contribution.agent] tried to parse field [agent] as object, but found a concrete value]

sihe TT050409948

See #38.
@dr0i dr0i added review and removed working labels Dec 8, 2016
dr0i added a commit that referenced this issue Dec 9, 2016
This is a workaround. "contributorOrder" will be removed in whole when #125
is solved.

Part of #38.
@acka47 acka47 removed their assignment Dec 13, 2016
fsteeg added a commit to hbz/nwbib that referenced this issue Dec 13, 2016
dr0i added a commit that referenced this issue Dec 15, 2016
- take just one preferred name into account, see TT001230001

See #38.
dr0i added a commit to hbz/lobid-rdf-to-json that referenced this issue Dec 15, 2016
@dr0i dr0i self-assigned this Dec 15, 2016
@dr0i dr0i added processing review and removed review labels Dec 15, 2016
@dr0i dr0i closed this in #131 Dec 20, 2016
@dr0i dr0i removed the review label Dec 20, 2016
@dr0i
Copy link
Contributor

@dr0i dr0i commented Dec 20, 2016

Deployed to staging and production, @acka47 please have a look.

@dr0i dr0i reopened this Dec 20, 2016
@dr0i dr0i assigned acka47 and unassigned dr0i Dec 20, 2016
@dr0i dr0i added review and removed processing labels Dec 20, 2016
@acka47
Copy link
Contributor Author

@acka47 acka47 commented Dec 20, 2016

+1. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.