New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"owner" parameter not working #949

Closed
acka47 opened this Issue Jan 9, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@acka47
Copy link
Contributor

acka47 commented Jan 9, 2019

Reported today by API user:

Heute musste ich leider feststellen, dass der bulk-Download keine Treffer mehr liefert. Das scheint an dem "Owner"-Parameter zu liegen und kann an dem Beispiel "Einschränkung auf Bestand in Bibliotheken" aus der API-Dokumentation nachvollzogen werden:

http://lobid.org/resources/search?q=kunst&owner=DE-290%2CDE-294&format=json

This is probably due to 8d5385b and hopefully can easily be fixed.

@acka47 acka47 added the bug label Jan 9, 2019

@acka47

This comment has been minimized.

Copy link
Contributor

acka47 commented Jan 9, 2019

We should add a test of the owner parameter to the test set.

@fsteeg

This comment has been minimized.

Copy link
Contributor

fsteeg commented Jan 9, 2019

Switched resources alias to resources-20181226-0100 index until this is fixed.

@fsteeg fsteeg added the working label Jan 9, 2019

fsteeg added a commit that referenced this issue Jan 9, 2019

Fix owner queries for `#!` suffixes
Also replace `hasChild` with simple `hasItem.heldBy.id` query
using item data which is now embedded in the actual resources.

See #949
@fsteeg

This comment has been minimized.

Copy link
Contributor

fsteeg commented Jan 9, 2019

fsteeg added a commit that referenced this issue Jan 9, 2019

Fix owner queries for `#!` suffixes
Also replace `hasChild` with simple `hasItem.heldBy.id` query
using item data which is now embedded in the actual resources.

See #949

@fsteeg fsteeg added review and removed working labels Jan 9, 2019

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Jan 9, 2019

@acka47

This comment has been minimized.

Copy link
Contributor

acka47 commented Jan 9, 2019

+1

@acka47 acka47 removed their assignment Jan 9, 2019

@acka47 acka47 added deploy and removed review labels Jan 9, 2019

@fsteeg fsteeg closed this in 4869f8d Jan 9, 2019

@fsteeg fsteeg removed the deploy label Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment