Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notations for Regierungsbezirke #99

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@acka47
Copy link
Contributor

commented Sep 10, 2019

See #89

@acka47 acka47 requested a review from fsteeg Sep 10, 2019

@fsteeg fsteeg merged commit 0a92d51 into master Sep 10, 2019

@fsteeg fsteeg deleted the 89-notations4regbezirke branch Sep 10, 2019

@fsteeg

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@acka47 Should these not be added as P439/P440 (AGS/KS) in Wikidata instead? With our current implementation, these notations are removed upon regenerating the SKOS file, since the Wikidata entries have no AGS/KS.

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Sep 10, 2019

@acka47

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

Should these not be added as P439/P440 (AGS/KS) in Wikidata instead? With our current implementation, these notations are removed upon regenerating the SKOS file, since the Wikidata entries have no AGS/KS.

Good to know that this will be overwritten. As these are neither Gemeinden nor Kreise but Regierungsbezirke, they officially do not have a AGS or KS and a "Regierungsbezirksschlüssel" does not exist, see #89 (comment).

However, there is the "Regionalschlüssel" and although it is usually characterized as "12-stelliger Schlüssel" (see e.g. here) it is used in Wikidata with less digits, e.g. Bayern has Regionalschlüssel 09).

To make a long story short: I added the Regionalschlüssel to the Regierungsbezirke and we should also add it as notation to the SKOS file but only when no ags or ks is present. (There are few Wikidata entries with NWBib ID – and it might be more in the future – that have more than one Schlüssel, see https://w.wiki/8C4.)

(You probably better make a separate issue for this.)

@acka47

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

With problems like hbz/nwbib#490 and NWbib editors saying that they will have to fake some keys for older Kreise (email by H.F. from 2019-05-02) we will probably have to set up an additional way to configure notations anyway. I looked for a way to add the notation as qualifier in Wikidata but didn't find anything. As last resort, we could propose a property or we set up a configuration file in the git repo...

@acka47 acka47 referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.