Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process new `contribution` structure in details views (#361) #362

Merged
merged 1 commit into from Dec 20, 2016

Conversation

@fsteeg
Copy link
Member

@fsteeg fsteeg commented Dec 13, 2016

Will resolve #361.

See also:

hbz/lobid-resources#38
hbz/lobid-resources#131

Deployed to staging, see http://test.nwbib.de/HT018776640

@fsteeg fsteeg added the review label Dec 13, 2016
@acka47
Copy link
Contributor

@acka47 acka47 commented Dec 13, 2016

Looks good, and obviously the order is taken into account when there are more agents with one role (e.g. http://test.nwbib.de/HT018501068 or http://test.nwbib.de/TT000302897, although the order in the JSON still differs from the source).

There is one thing we have to adjust on the transformation side: The label for "Creator" (i.e. "Creator") is not correct, we will have to adjust the labels.json for this, see e.g. http://test.nwbib.de/HT014996961

I realized that we also can remove the "Schlagwortfolge" line by now as the subjects already come in a sorted array. But the order is not taken for the HTML representation, see e.g. http://test.nwbib.de/HT014013953 in comparison to http://test.lobid.org/resources/HT014013953.

@acka47
Copy link
Contributor

@acka47 acka47 commented Dec 20, 2016

+1

@acka47 acka47 assigned dr0i and unassigned acka47 Dec 20, 2016
@dr0i
Copy link
Contributor

@dr0i dr0i commented Dec 20, 2016

+1

@dr0i dr0i added deploy and removed review labels Dec 20, 2016
@dr0i dr0i assigned fsteeg and unassigned dr0i Dec 20, 2016
@fsteeg fsteeg merged commit a2b0543 into master Dec 20, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@fsteeg fsteeg removed the deploy label Dec 20, 2016
@acka47 acka47 deleted the 361-contribution branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants