Process new contribution structure in details views (#361)
#362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good, and obviously the order is taken into account when there are more agents with one role (e.g. http://test.nwbib.de/HT018501068 or http://test.nwbib.de/TT000302897, although the order in the JSON still differs from the source). There is one thing we have to adjust on the transformation side: The label for "Creator" (i.e. "Creator") is not correct, we will have to adjust the labels.json for this, see e.g. http://test.nwbib.de/HT014996961 I realized that we also can remove the "Schlagwortfolge" line by now as the subjects already come in a sorted array. But the order is not taken for the HTML representation, see e.g. http://test.nwbib.de/HT014013953 in comparison to http://test.lobid.org/resources/HT014013953. |
fsteeg
added a commit
to hbz/lobid-blog
that referenced
this pull request
Dec 13, 2016
acka47
added a commit
to hbz/lobid-rdf-to-json
that referenced
this pull request
Dec 14, 2016
Contributor
|
+1 |
Member
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve #361.
See also:
hbz/lobid-resources#38
hbz/lobid-resources#131
Deployed to staging, see http://test.nwbib.de/HT018776640