Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move narrower entries of 52/72 under 54/74 #505

Open
wants to merge 7 commits into
base: master
from

Conversation

@acka47
Copy link
Contributor

acka47 commented Nov 7, 2019

Fixes #503 and delivers parts for #502. Should also fix #504.

See #503
@acka47 acka47 requested a review from fsteeg Nov 7, 2019
@acka47 acka47 added this to Working in NWBib-Raumsystematik via automation Nov 7, 2019
@acka47 acka47 moved this from Working to Review in NWBib-Raumsystematik Nov 7, 2019
fsteeg added a commit to hbz/lobid-vocabs that referenced this pull request Nov 8, 2019
See #505
@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Nov 8, 2019

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Nov 8, 2019
@fsteeg fsteeg removed their request for review Nov 8, 2019
fsteeg added a commit to hbz/lobid-vocabs that referenced this pull request Nov 8, 2019
@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Nov 8, 2019

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Nov 8, 2019

As mentioned in #504, to three new places in Wikidata, a NWBib ID was added and they are also used in cataloging:

  1. Oelgershausen (Q1528807), see http://lobid.org/resources/HT020155665.json
  2. Langeland (Q1804946), see http://lobid.org/resources/HT020213557.json
  3. Schallern (Q2230503), see http://lobid.org/resources/HT018868330.json

Strangely, only one of those (2. Langeland) is added to the SKOS file by the linked commit. Why not the other two?

@acka47 acka47 assigned fsteeg and unassigned acka47 Nov 8, 2019
@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Nov 11, 2019

Strangely, only one of those (2. Langeland) is added to the SKOS file by the linked commit.

Hm, so actually none should have been added at this point, since we did not update from Wikidata.

Maybe Langeland was already in the Wikidata state we used, but only now used in the catalog?

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Nov 11, 2019

Maybe Langeland was already in the Wikidata state we used, but only now used in the catalog?

NWBib-ID for Langeland (Q1804946) was added on 2019-10-24: https://www.wikidata.org/w/index.php?title=Q1804946&type=revision&diff=1038184245&oldid=1038183382, sames as for Oelgershausen (https://www.wikidata.org/w/index.php?title=Q1528807&type=revision&diff=1038139289&oldid=1029147613).

Schallern got an NWBib-ID already on 2019-10-15, see https://www.wikidata.org/w/index.php?title=Q2230503&type=revision&diff=1032312364&oldid=998515694

So this can not be the reason.

@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Nov 11, 2019

I checked the test deployment data, and in that, of these three, only Langeland has partOf information.

fsteeg added a commit to hbz/lobid-vocabs that referenced this pull request Nov 11, 2019
@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Nov 11, 2019

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Nov 11, 2019

Looks good except of one thing: Why is "Kreis Lemgo" (Q1543152) removed although the wikidata entry has an NWBib-ID (see https://www.wikidata.org/wiki/Q1543152) and there is one lobid resource that has it in spatial, see https://lobid.org/resources/HT017077527.json?

fsteeg added a commit to hbz/lobid-vocabs that referenced this pull request Nov 12, 2019
@fsteeg

This comment has been minimized.

Copy link
Member

fsteeg commented Nov 12, 2019

Not sure why, but when I re-generate the SKOS file, Kreis Lemgo is in:

https://test.nwbib.de/spatial
hbz/lobid-vocabs@53b2abf
https://github.com/hbz/lobid-vocabs/pull/104/files

@acka47

This comment has been minimized.

Copy link
Contributor Author

acka47 commented Nov 12, 2019

+1 This looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.