Skip to content

Ignore diff in blank lines when posting issue back to github #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ignore diff in blank lines when posting issue back to github #6819

wants to merge 1 commit into from

Conversation

@akhismat
Copy link
Contributor

@akhismat akhismat commented Oct 5, 2024 •
edited by huly-github-staging bot
Loading

Ignore diff in blank lines when posting issue back to github

@akhismat
Ignore diff in blank lines when posting issue back to github
42c48bd 
Signed-off-by: Anna Khismatullina <anna.khismatullina@gmail.com>
@akhismat akhismat requested a review from aonnikov October 5, 2024 09:37
haiodo
haiodo reviewed Oct 5, 2024
View reviewed changes
packages/text/src/markdown/compare.ts
.split('\n')
.map((it) => it.trimEnd())
.join('\n')
const normalizeLineEndings = (str: string) =>
Copy link
Contributor

@haiodo haiodo Oct 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If comments will not be supported we will potentially break description on github, let's support html/comments first and then add a trim of lines >2 into 1 into comparison, but not allow without line and with line be the same.

Copy link
Contributor Author

@akhismat akhismat Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fyi: even with this change description with comment and without comment will not be equal.

haiodo
haiodo suggested changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@haiodo haiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not ready to merge it before comments will be supported.

@akhismat
Copy link
Contributor Author

akhismat commented Oct 8, 2024 •
edited
Loading

@haiodo
There are two independent problems:

  1. Extra empty lines.
  2. Comments, which are not yet supported. Huly just removes them from a description and never put the issue back to GitHub because the description was changed.

This PR has fix only for №1:
Allow put issue back if changes are in empty lines only.

№2 is in progress
But even with this change Huly will never re-write the description in case the original issue has comments in the description.

Are you OK with this fix for №1 only?

@akhismat akhismat marked this pull request as draft October 9, 2024 16:58
@akhismat akhismat closed this Dec 10, 2024
@akhismat akhismat deleted the ignore-diff-in-blank-lines branch December 10, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aonnikov aonnikov Awaiting requested review from aonnikov

1 more reviewer

@haiodo haiodo haiodo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akhismat @haiodo