Skip to content

Ignore diff in blank lines when posting issue back to github #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Ignore diff in blank lines when posting issue back to github #6819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions packages/text/src/markdown/compare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,20 @@ export function calcSørensenDiceCoefficient (a: string, b: string): number {
* Perform markdown diff/comparison to understand do we have a major differences.
*/
export function isMarkdownsEquals (source1: string, source2: string): boolean {
const lines1 = source1
.split('\n')
.map((it) => it.trimEnd())
.join('\n')
const lines2 = source2
.split('\n')
.map((it) => it.trimEnd())
.join('\n')
const normalizeLineEndings = (str: string) =>
Copy link
Contributor

@haiodo haiodo Oct 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If comments will not be supported we will potentially break description on github, let's support html/comments first and then add a trim of lines >2 into 1 into comparison, but not allow without line and with line be the same.

Copy link
Contributor Author

@akhismat akhismat Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fyi: even with this change description with comment and without comment will not be equal.

str.replace(/\r?\n/g, '\n');

const excludeBlankLines = (str: string) =>
str.split('\n')
.map((it) => it.trimEnd())
.filter(it => it.length > 0)
.join('\n')

const norm1 = normalizeLineEndings(source1)
const lines1 = excludeBlankLines(norm1)

const norm2 = normalizeLineEndings(source2)
const lines2 = excludeBlankLines(norm2)

return lines1 === lines2
}